From dd50db75cd68b52d98bea97dc4e9caedfb67ec54 Mon Sep 17 00:00:00 2001 From: Dien-Nhung Nguyen-Phu Date: Sat, 11 May 2024 08:34:13 +0700 Subject: [PATCH 1/2] chore: revert Timber to 4.7.1 Current build system cannot load Timber 5.0.1 lint check. This cause a lot garbage in build log. --- android/build.gradle | 2 +- .../java/org/fossasia/badgemagic/core/android/log/TimberKt.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index f1a24e9c3..ddcc542b0 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -101,7 +101,7 @@ dependencies { implementation 'com.google.android.material:material:1.4.0' //Timber - implementation 'com.jakewharton.timber:timber:5.0.1' + implementation 'com.jakewharton.timber:timber:4.7.1' implementation 'no.nordicsemi.android.support.v18:scanner:1.6.0' diff --git a/android/src/main/java/org/fossasia/badgemagic/core/android/log/TimberKt.kt b/android/src/main/java/org/fossasia/badgemagic/core/android/log/TimberKt.kt index 0b35f30cb..c6aceadbc 100644 --- a/android/src/main/java/org/fossasia/badgemagic/core/android/log/TimberKt.kt +++ b/android/src/main/java/org/fossasia/badgemagic/core/android/log/TimberKt.kt @@ -130,5 +130,5 @@ inline fun wtf(t: Throwable) = Timber.wtf(t) /** @suppress */ @PublishedApi internal inline fun log(block: () -> Unit) { - if (Timber.treeCount > 0) block() + if (Timber.treeCount() > 0) block() } From fa529cde6cee1332234bbe40a4cfa2842d9ba4da Mon Sep 17 00:00:00 2001 From: Dien-Nhung Nguyen-Phu Date: Sat, 11 May 2024 10:31:27 +0700 Subject: [PATCH 2/2] chore: fix build log was flooded with warnings This caused by having different versions of kotlin module --- android/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/android/build.gradle b/android/build.gradle index ddcc542b0..57c0ee360 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -82,6 +82,7 @@ dependencies { implementation project(':BadgeMagicModule') implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${versions.kotlin_version}" + implementation "org.jetbrains.kotlin:kotlin-reflect:${versions.kotlin_version}" kapt "androidx.databinding:compiler:3.2.0-alpha11"