Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link redirect of current day results in user forward to wrong filtered page #7016

Closed
mariobehling opened this issue Mar 17, 2021 · 6 comments · Fixed by #9145
Closed

Link redirect of current day results in user forward to wrong filtered page #7016

mariobehling opened this issue Mar 17, 2021 · 6 comments · Fixed by #9145

Comments

@mariobehling
Copy link
Member

We now have the feature that the user is directed automatically to the session of the current day if the date is within the event date. However if a user has a direct link, e.g. to https://eventyay.com/e/fa96ae2c/schedule?search=nick, then the use is instead directed to https://eventyay.com/e/fa96ae2c/schedule?date=2021-03-17&search=nick. This gets the user to the wrong page.

@sachinchauhan2889
Copy link
Contributor

sachinchauhan2889 commented Mar 17, 2021

@mariobehling sir i am looking into this.

Can you please tell me desired functionality.

we want current day schedule when event is running. I am having doubt, when we need to show current day schedule.

  1. Do we want current day schedule when someone visit https://eventyay.com/e/fa96ae2c/schedule directly??

                                        OR
    
  2. we want current day schedule only when user visit https://eventyay.com/e/fa96ae2c/schedule, But we don't want current day schedule when user visit schedule page directly with some applied filters example:- https://eventyay.com/e/fa96ae2c/schedule?seaarch=nick

@vartikaSaxena
Copy link

Hey, @mariobehling I find this issue interesting, can I work on it?

@pranav1311
Copy link

Hey @mariobehling i understand that the issue is that user is getting not particular date page and instead all , i can contribute and solve this issue , how can i submit proposal ?

@maze-runnar
Copy link
Contributor

Couldn't find the exact way, but popping the filter would work like -

if(datefilterisactive && params.search) {
   filterOptions = null;
  filteroption for searching;
}else{
  restore previous filters;
}

@Prince-yohannan
Copy link

hello sir can i work in it

@progmatic-99
Copy link
Contributor

progmatic-99 commented Aug 21, 2021

I am not able to reproduce this.
Are you still encountering this?? @mariobehling

@ghost ghost moved this from Inbox to In Progress in eventyay V2.5 Aug 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in eventyay V2.5 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants