Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

massive gas estimation when running forge script on base #7400

Closed
2 tasks done
colinnielsen opened this issue Mar 14, 2024 · 2 comments · Fixed by #7106
Closed
2 tasks done

massive gas estimation when running forge script on base #7400

colinnielsen opened this issue Mar 14, 2024 · 2 comments · Fixed by #7106
Labels
T-bug Type: bug

Comments

@colinnielsen
Copy link
Contributor

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (545cd0b 2024-03-14T00:20:00.210934000Z)

What command(s) is the bug in?

forge script

Operating System

macOS (Apple Silicon)

Describe the bug

Blob storage was released today on Base, and I am using forge script to run a transaction through a new contract.

Repro steps:

  1. clone the repo off this pr / branch Token Factory v2 0xmetropolis/erc20#3
  2. run export OWNER=rando_addr
  3. run forge script script/DeployToken.s.sol --rpc-url https://mainnet.base.org
@colinnielsen colinnielsen added the T-bug Type: bug label Mar 14, 2024
@0xAndoroid
Copy link
Contributor

Adding --legacy flag solves the issue, but you are right, priority fees are overestimated. I'm going to try to spot the issue and submit a pr.

@0xAndoroid
Copy link
Contributor

0xAndoroid commented Mar 16, 2024

This is a duplicate of #5709

@Evalir why aren't you considering implementing custom estimator function in foundry? ethers' accepts

fn estimator(base_fee: U256, history: Vec<Vec<U256>>) -> (U256, U256)

in estimate_eip1559_fees(estimator)

.estimate_eip1559_fees(None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants