Request to update dictionary to fuzz on smart values

[snreynolds]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (f625d0f 2024-04-02T00:16:42.810315000Z)

What command(s) is the bug in?

forge test

Operating System

None

Describe the bug

We recently manually caught an outdated fuzz test that should have thrown had a correct input been chosen. See this PR for reference/repro

https://github.com/Uniswap/v4-core/pull/529/files

[klkvr]

Thanks for reporting this! It's a nice example of fuzzer downside and #7552 should decrease number of runs this test needs to fail, however, it will still be very high :/

This is happening due to test having several branches, and most of the runs are not hitting the one which should fail, thus decreasing its chance to be executed with failing input.

I'd recommend rewriting this test into several separate tests to ensure that all scenarios are covered by high number of runs

[zerosnacks]

cc @grandizzy do you see any actionable item for this ticket that we can improve upon?

[grandizzy]

cc @grandizzy do you see any actionable item for this ticket that we can improve upon?

I think that's more suitable for symbolic testing which we track to implement with #15