Attack rolls below target AC are highlighted red even if the roll is a critical success

[roth-michael]

See below:

Should just be a matter of changing

if ( d20Roll.total >= d.options.target ) total.classList.add("success");

to

if ( d20Roll.total >= d.options.target || (canCrit && d20Roll.isCritical) ) total.classList.add("success");

[roth-michael]

Technically both the fumble and success classes are added in the opposite scenario (a natural 1 but a bonus that lifts it above AC) but that doesn't matter, since it seems fumble takes priority over success

[Fyorl]

That's how it's intended to be handled in the case of this bug as well: critical styles should take priority over the failure styles.

[roth-michael]

Ah gotcha so the ideal solution would be a css one, not a code change as outlined above? (I ask because I'll make a PR if desired)

[Fyorl]

Yeah that would be ideal, thanks