Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying advantage mode to D20Die doesn't remove former advantage modifiers #4622

Closed
etiquettestartshere opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
bug Functionality which is not working as intended system: dice Dice rolling functionality
Milestone

Comments

@etiquettestartshere
Copy link
Contributor

Messing around with the roll refactor and it seems concentration saving throws with with advantage are currently quite weird. With concentration advantage, the dialog shows me 2d20kh, but has NORMAL highlighted by default, and normal button or enter result in 1d20kh. manually hitting ADVANTAGE gives me 2d20khkh, and DISADVANTAGE gives me 2d20khkl. Sorry if this is already known/to be fixed, was just told to point it out cause I happened to see it.

image

(note: the 1d4 in these screenshots is from bless, which is always on my akra from other testing, sorry)

This, the default with advantage from the concentration config...
image
results in:
image

Manually hitting advantage...
image
results in:
image
And finally manually hitting disadvantage...
image
results in:
image

@arbron arbron changed the title [4.1.x] Potential issues with concentration advantage mode Applying advantage mode to D20Die doesn't remove former advantage modifiers Nov 1, 2024
@arbron arbron added bug Functionality which is not working as intended system: dice Dice rolling functionality labels Nov 1, 2024
@arbron arbron self-assigned this Nov 1, 2024
@arbron arbron added this to the D&D5E 4.1.0 milestone Nov 1, 2024
@arbron arbron closed this as completed in f82a146 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended system: dice Dice rolling functionality
Projects
None yet
Development

No branches or pull requests

2 participants