Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agree upon a schema for tracking effects which provide advantage or disadvantage to a certain type of roll. #809

Closed
aaclayton opened this issue Nov 12, 2020 · 10 comments

Comments

@aaclayton
Copy link
Contributor

I don’t think that the core dnd5e system will ever automate the choice of advantage/disadvantage to a dice roll. However, we can have a discussion about how to store/record that data so that modules can use it to perform that type of automation.

Tentative Proposal

Step 1 - agree on a taxonomy of roll types which are tracked in an object like:

advantages: {
  "check:skill:ath": 1, // 1 = advantage
  "check:skill:ste": -1, // -1 = disadvantage
  "attack:mwak": 1,
  "check:save:str": 1,
  "check:test:str": 1
};

Step 2 - Which could then be configured on an active effect as:

image

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @cs96and

Why does the first part of the key use dots, but after "check" everything uses colons? I think using dots all the way through would be less confusing.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @tposney

  • consider adding all for each of the terminal options as well. e.g. flags.advantages.attack:all
  • The "check" seems superfluous in the outlined schema.
  • Also prefer . throughout rather than : at points that might not be clear to all users.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @siliconsaint

Advantage on saves vs conditions & spells

Should we consider allowing advantage against acquiring new conditions (poisoned, charmed, frightened) as well as advantage vs spells.

Examples:

  • Belt of Dwarvenkind - You have advantage on saving throws against poison
  • Robe of the Archmagi - You have advantage on saving throws against spells and other magical effects.
  • Elves have advantage on saving throws against being charmed
  • Halflings have advantage on saving throws against being frightened

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @siliconsaint

Advantage on saves vs Creature types

The type of a creature is often referenced with saving throws. Having advantage against a saving throw vs a certain type of creature, or a type has disadvantage to resist a save.

Examples:

  • Holy Nimbus: you have advantage on saving throws against spells cast by fiends or undead.
  • Sunburst: Undead and oozes have disadvantage on this saving throw.
  • Sunbeam: Undead and oozes have disadvantage on this saving throw.
  • Moonbeam: A Shapechanger makes its saving throw with disadvantage.
  • Protection from Evil and Good: disadvantage on attack rolls against the target aberrations, celestials, elementals, fey, fiends, and undead
  • Favored Enemy: You have advantage on Wisdom (Survival) checks to track your favored enemies, as well as on Intelligence checks to recall information about them.

@aaclayton
Copy link
Contributor Author

Advantage that applies to a specific creature type is almost certainly out of scope for actually doing anything, although it could possibly be in-scope for the purpose of at least recording the data somehow.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @kandashi

This would also allow this to be tracked on the actor sheet (core or not) which would provide usefull feedback to the user as well. Slightly linked to #874

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @tposney

I can see a potential problem with the proposed numeric adv/dis. If a player has advantage/disadvantage on the same roll from different effects, i.e. one effect granting advantage and 2 granting disadvantage, which should result in a roll without advantage or disadvantage. If you just override the flag you end with what happened to fire last and if it's the sum you end up with the wrong result.

I could not come up with a good solution for this with a single flag which is why I have distinct advantage/disadvantage flags and when doing the roll you can see if advantage/disadvantage has been set and do the right combining.

@Ikaguia
Copy link
Contributor

Ikaguia commented Dec 20, 2023

Was this ever agreed upon or was is just abandoned?

@revilowaldow
Copy link

Would love to see this support labels on the new character sheet in a similar style to D&D beyond

@Fyorl Fyorl removed this from the Compendium Active Effects milestone Oct 3, 2024
@Fyorl
Copy link
Contributor

Fyorl commented Oct 3, 2024

The schema is now in place with the implementation of the RollConfigField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants