Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reliable Talent skill floor message not modify by Minimum Roll #899

Open
Enielka opened this issue Dec 12, 2024 · 0 comments
Open
Labels
bug Functionality which is not working as intended dnd-tashas-cauldron Issues related to Tasha's Cauldron of Everything

Comments

@Enielka
Copy link

Enielka commented Dec 12, 2024

What happened?

In 4.1.2, in the modifyRollFloorMessage function of the check-upgrades.mjs script
The conditions for modifying the message are no longer correct.

On line 133, replace message.getFlag(“dnd5e”, “roll.rollFloor”) with message.getFlag(“dnd5e”, “roll.type”)
On line 134, replace message.rolls[0]?.dice[0]; with message.rolls[0]?.terms[0];
On line 135, replace (${game.i18n.localize(“DND5E.FlagsReliableTalent”)}) with ${game.i18n.localize(“DND5E.FlagsReliableTalent”)}.

However, I have my doubts about the usefulness of the condition message.getFlag(“dnd5e”, “roll.rollFloor”)

And maybe modify the modifyRollFloor method on line 44.

What package are you reporting this for?

Tasha's Cauldron of Everything

Version

1.3.0

Relevant log output

No response

@Enielka Enielka added the bug Functionality which is not working as intended label Dec 12, 2024
@github-actions github-actions bot added the dnd-tashas-cauldron Issues related to Tasha's Cauldron of Everything label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended dnd-tashas-cauldron Issues related to Tasha's Cauldron of Everything
Projects
None yet
Development

No branches or pull requests

1 participant