From 1bd20a0d12bc0bde13c4707395f437f53e62fa51 Mon Sep 17 00:00:00 2001
From: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
Date: Sat, 25 Jan 2025 16:45:46 -0600
Subject: [PATCH] Attempt to use compendium indexes to get names of
 self-applied effects in item summaries (#18112)

---
 src/module/actor/sheet/item-summary-renderer.ts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/module/actor/sheet/item-summary-renderer.ts b/src/module/actor/sheet/item-summary-renderer.ts
index 7b7a7cd3f17..40350a2a119 100644
--- a/src/module/actor/sheet/item-summary-renderer.ts
+++ b/src/module/actor/sheet/item-summary-renderer.ts
@@ -97,9 +97,13 @@ export class ItemSummaryRenderer<TActor extends ActorPF2e, TSheet extends Applic
         chatData: RawItemChatData,
     ): Promise<void> {
         const isEffect = item instanceof AbstractEffectPF2e;
-        const effectLinkText =
-            item.isOfType("action", "feat") && item.system.selfEffect ? `@UUID[${item.system.selfEffect.uuid}]` : null;
-        const selfEffect = effectLinkText && (await TextEditor.enrichHTML(effectLinkText));
+        const selfEffectLink = (() => {
+            if (!item.isOfType("action", "feat") || !item.system.selfEffect) return null;
+            const uuid = item.system.selfEffect.uuid;
+            const effectItem = fromUuidSync(uuid);
+            const name = effectItem?.name ?? item.system.selfEffect.name;
+            return `@UUID[${uuid}]{${name}}`;
+        })();
 
         const summary = await renderTemplate("systems/pf2e/templates/actors/partials/item-summary.hbs", {
             item,
@@ -107,7 +111,7 @@ export class ItemSummaryRenderer<TActor extends ActorPF2e, TSheet extends Applic
             identified: game.user.isGM || !(item.isOfType("physical") || isEffect) || item.isIdentified,
             isCreature: item.actor?.isOfType("creature"),
             chatData,
-            selfEffect,
+            selfEffect: selfEffectLink && (await TextEditor.enrichHTML(selfEffectLink)),
         });
 
         container.innerHTML = summary;