Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Exclude filetypes #123

Closed
3 tasks done
andyylin opened this issue Dec 30, 2024 · 15 comments
Closed
3 tasks done

[FR] Exclude filetypes #123

andyylin opened this issue Dec 30, 2024 · 15 comments
Labels
feature request New feature or request

Comments

@andyylin
Copy link

First Steps

  • I've ensured that this feature request does not already exist by using the search feature
  • I've read the documentation (see the README)
  • I'm on the latest release of obsidian-list-modified

Describe the desired feature

Add an option to exclude by filetype. I am using Edit History which creates *.edtz files that keep file history for corresponding files. I am unable to exclude them from List Modified though so they show up in my Daily Note.

Possible alternatives

What are some possible alternatives? Have you tried any of them?

Additional info?

@franciskafieh franciskafieh added the feature request New feature or request label Dec 31, 2024
@franciskafieh
Copy link
Owner

I will look into adding this, thank you!

As a temporary workaround, are you able to have your edtz files outputting into a specific directory, which you can exclude with the plugin? Or have them prefixed and use the named excludes?

Either way, I will look into this.

@andyylin
Copy link
Author

andyylin commented Jan 1, 2025

Thank you for the suggestion! Unfortunately, the plugin doesn't have an option for outputting to a directory. I think that makes sense as its most straightforward to keep the history file right next to the original file.

Thanks for looking into this! Happy new year.

@franciskafieh
Copy link
Owner

Hi there. Just to clarify: These show up in your deleted header, right?

@andyylin
Copy link
Author

They are history files that record changes to a note, so they show up under the modified header. They probably show up under Deleted as well if the associated note is deleted.

@franciskafieh
Copy link
Owner

franciskafieh commented Jan 15, 2025

so they show up under the modified header.

I have downloaded the Edit History plugin to test this and I cannot reproduce the .edtz files showing up in the modified header. I can only get them to show up in deleted, which I can release a fix for.

The way the plugin tracks changes should automatically exclude stuff that is not a note.

If you are sure they show up in your modified header, would you be able provide me with a way to reproduce this?

Thanks.

@andyylin
Copy link
Author

andyylin commented Jan 16, 2025

You're right, it only shows up under the DELETED header. Thanks for finding a fix for this.

image

@franciskafieh
Copy link
Owner

Please see release 3.4.0, which has added an "exclude filetypes setting." Feel free to re-open if this does not solve your issue or if you have any further questions.

@andyylin
Copy link
Author

With 3.4.0, my excluded EDTZ files are showing up under Created (but at last not under Modified).

@andyylin
Copy link
Author

andyylin commented Jan 21, 2025

On a related note, I'm getting conflicts with the Local Images Plus plugin, which saves remote images to the local disk. It seems to go into a recursive loop where List Modified makes a link to the newly downloaded image, then Local Images Plus processes it, which List Modified then records, and so on.

This is despite setting excluded filetypes to be edtz, webp, jpg, jpeg, png

The only fix at the moment if I want to retain local images is to disable List Modified.

@franciskafieh
Copy link
Owner

Okay, so I guess I have to add back the code I originally had to also exclude file types from create/modify.

give me a few days, I am really busy with exams right now, and I will do this for you

@franciskafieh
Copy link
Owner

Should be fixed in 3.4.1, but since I cannot re-produce your issue, I will re-open. Please update your plugin and let me know if the problem persists.

@franciskafieh franciskafieh reopened this Jan 26, 2025
@franciskafieh
Copy link
Owner

Any updates?

@andyylin
Copy link
Author

andyylin commented Jan 29, 2025 via email

@andyylin
Copy link
Author

Looks like it's working now @franciskafieh . I tested it with Local Images Plus and it's not going into a recurring loop any more with the converted images. Thanks again!

@franciskafieh
Copy link
Owner

franciskafieh commented Jan 31, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants