Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

POM should not export dependecy on gwt-user #65

Closed
GoogleCodeExporter opened this issue Mar 13, 2015 · 2 comments
Closed

POM should not export dependecy on gwt-user #65

GoogleCodeExporter opened this issue Mar 13, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Currently gwt-log's POM exports a transitive dependency on gwt-user. This 
causes gwt-user to make its way all the way into a project's WEB-INF/lib 
directory, where it should not be. If a project needs GWT code in its webapp, 
it would add a dependency on gwt-servlet, which goes in the WEB-INF/lib 
directory.

When a project is built using GWT (in Maven), the gwt-maven-plugin 
automatically adds gwt-user to the classpath, so it never needs to be expressed 
as a dependency in the GWT build. AFAIK, Eclipse operates similarly. If a 
project uses its GWT classes in the JVM as well (i.e. it has a webapp and 
perhaps uses GWT RemoteServiceServlets), then it should declare a dependency on 
gwt-servlet.

Libraries (like gwt-log) should declare a <scope>provided</scope> dependency on 
gwt-user so that they can compile against GWT classes, but they should not 
export any GWT dependency unless they are specifically designed for use both on 
the client and server (in which case they would export a gwt-servlet 
dependency).

Original issue reported on code.google.com by [email protected] on 2 Feb 2012 at 5:48

@GoogleCodeExporter
Copy link
Author

Thanks for the suggestion.

Is this what you intended?
http://code.google.com/p/gwt-log/source/diff?spec=svn8e596626c374e01d74dc6f71601
eee90f6df1c25&r=8e596626c374e01d74dc6f71601eee90f6df1c25&format=side&path=/Log/p
om.xml

Original comment by fredsa on 2 Feb 2012 at 10:05

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by fredsa on 9 Feb 2012 at 10:59

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant