Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies with <>& are escaped with HTML entities #645

Closed
eloquence opened this issue Dec 6, 2019 · 2 comments · Fixed by #703
Closed

Replies with <>& are escaped with HTML entities #645

eloquence opened this issue Dec 6, 2019 · 2 comments · Fixed by #703
Labels
bug Something isn't working
Milestone
Initial beta release

Comments

@eloquence
Copy link
Member

STR

Send the following reply:
hi, you & I should discuss -> signal?

Expected result:

Reply shows up as typed.

Actual result:

Reply shows up as hi, you &amp; I should discuss -&gt; signal?
@eloquence eloquence added the bug Something isn't working label Dec 6, 2019
@emkll
Copy link
Contributor

emkll commented Dec 10, 2019

This was likely introduced via ab77ac7 .

It seems like the easiest path to resolution would be to call setTextFormat(Qt.PlainText) before calling setText and not using html.escape. We could also consider overriding setTextFormat in SecureQLabel to prevent setting the text format to something else).

@eloquence eloquence added this to the 0.2.0beta milestone Dec 17, 2019
@emkll emkll mentioned this issue Dec 18, 2019
Closed
@ntoll
Copy link
Contributor

ntoll commented Jan 16, 2020

See #703

@ntoll ntoll mentioned this issue Jan 16, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Initial beta release
Development

Successfully merging a pull request may close this issue.

Fix HTML entities being escaped in speech bubbles. ntoll/securedrop-client
3 participants
@ntoll @eloquence @emkll