Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decorators for failure and success callbacks #651

Closed
sssoleileraaa opened this issue Dec 9, 2019 · 1 comment
Closed

Use decorators for failure and success callbacks #651

sssoleileraaa opened this issue Dec 9, 2019 · 1 comment

Comments

@sssoleileraaa
Copy link
Contributor

Description

Follow-up for #612 (comment):

create a decorator @success_callback and put any per-success logic in there along with our explanation of why it's needed, and then decorate any success callbacks with it. It's the same size diff, but it's a bit more extensible. We could also do the same for the failure callback to ensure that all failures have a log line (since most of our failure callbacks have a debug line to log a failure, we could put that in a generic place too to ensure that we're logging these failures).
~@redshiftzero

@eloquence
Copy link
Member

From 2022-08-15 review with @gonzalo-bulnes
@eloquence:

  • Closing as stale, refactor target would need to be specified a bit more clearly on the basis of the current code and behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants