Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ConversationView.add_reply_from_reply_box #821

Open
redshiftzero opened this issue Feb 25, 2020 · 1 comment
Open

remove ConversationView.add_reply_from_reply_box #821

redshiftzero opened this issue Feb 25, 2020 · 1 comment
Labels
needs discussion

Comments

@redshiftzero
Copy link
Contributor

do we really need add_reply_from_reply_box? This is one path to widgets getting added to the conversation view outside of calls to update_conversation. It seems unnecessary now: in on_reply_sent here we should be able to call update_conversation instead of this additional method add_reply_from_reply_box (source.collection has the DraftReply object which will be created immediately when we click send).

Originally posted by @redshiftzero in #653 (comment)
This was referenced Feb 25, 2020
Open
Closed
@zenmonkeykstop
Copy link
Contributor

Needs investigation to see if it's still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ConversationView.add_reply_from_reply_box freedomofpress/securedrop-client
2 participants
@zenmonkeykstop @redshiftzero