Adds initial packaging for securedrop-log #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
reviewed
Dec 6, 2019
redshiftzero
force-pushed
the
package_log
branch
from
1972e8d to
fa630e0
Compare
redshiftzero
suggested changes
Dec 6, 2019
kushaldas
force-pushed
the
package_log
branch
from
fa630e0 to
64a153b
Compare
redshiftzero
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
I added two commits, adding a CI job to test and a small fix, otherwise this looks good to me
@kushaldas I'm going to let you review my changes and merge
|
@redshiftzero Those two new commits look good to me. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Buster package for the securedrop-log package.
How to test?
python3 setup.py sdistPKG_VERSION=0.0.1 PKG_PATH=/home/user/project/securedrop-log/dist/securedrop-log-0.0.1.tar.gz make securedrop-logRemember to change the path based on your actual code path.