Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create securedrop-app-code Debian package with Python 3 dependencies #4355

Closed
eloquence opened this issue Apr 18, 2019 · 6 comments · Fixed by #4622
Closed

Create securedrop-app-code Debian package with Python 3 dependencies #4355

eloquence opened this issue Apr 18, 2019 · 6 comments · Fixed by #4622
Assignees
Milestone

Comments

@eloquence
Copy link
Member

Now that we have basic Python 3 compatibility (#997, resolved through #4239), we need to ensure that all the securedrop-app-code dependencies transition to Python 3 as well. The plan of record is to use dh-virtualenv to ship these dependencies in the package itself, instead of depending on the system Python libraries.

This will allow us to use consistent dependency management processes for SecureDrop Workstation and SecureDrop core, and will get us closer to resolving #3407.

@eloquence
Copy link
Member Author

For the 4/17-5/1 sprint, Kushal will prepare at least a draft PR for broader team input, which will not use FPF's PyPI mirror yet.

@redshiftzero
Copy link
Contributor

hey @kushaldas what is the status of this?

@redshiftzero
Copy link
Contributor

can you push up whatever wip you have when you get a chance @kushaldas ?

@kushaldas
Copy link
Contributor

I did not manage to work on this enough during that sprint, but, I have other WIP work on my backup system (a make clean removed from my laptop during the last trip). I will push it here with details of things needs to be done.

@redshiftzero
Copy link
Contributor

please push up whatever wip you have locally so @rmol can check it out since y'all will be working together next sprint to get the combined mod_wsgi changes and this issue merged together.

@redshiftzero redshiftzero added this to the 1.0.0 milestone Jun 19, 2019
@kushaldas
Copy link
Contributor

I pushed #4555 to show the changes I made for a debian python3 package using dh-virtualenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants