-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next round of Pray and Pay revisions #4845
Comments
Another thing, sorry, these are going to trickle in. This doesn't work if people don't have RECAP installed, so if people click the buttons to buy things, we should make sure they have RECAP installed before sending them to PACER. I think we have this functionality elsewhere, so we just need to bring it to these buttons too (if we haven't already). |
I'll take a bit to digest your comments, but regarding (2), aren't the buttons present on those pages? See this example in the bottom right. |
Yeah, ok, that's fine. Thank you! |
Hm, I took a quick look at those two entries and discovered they were both created by the
That's the system account used by the RECAP extension. @ERosendo, any chance you made these prayers while debugging the API or something? Maybe we can just delete them. |
@mlissner I don't remember making those exact prayers, but it's likely they were produced while I was experimenting with the prayer-creation logic.
I think It's fine to delete those records. I reviewed some dockets, and the prayer button is not accessible for minute entries. Users won't be able to create similar prayers in the future. |
So deleted. |
Thanks. You can delete the DDC entry too. I think it's not possible to purchase. |
Just caught a strange bug where if I request a document directly via the API linked below, the counts on the icons don't increase on the particular docket pages. |
Remember: We see different things when we look at that API, but of the four prayers in the leaderboard, they all show a count of 1. Seems OK to me? |
I deleted the requests as they were just a test. If you try posting new ones via the endpoint and then checking the particular dockets to see the prayer counts for those items, they should remain at 0. |
Is the code for the upcoming opinion page redesign available anywhere? |
It is, hunt for the |
I found it in the view but not the html. Is the front end not pushed to production yet? (I wanted to graft the code onto these pages.) |
It's pushed but the flag is still disabled. I just opted you into it though, so if you refresh you should see the new pages live. One thing to note though is that there are still a few fixes needed, including to the buttons. The parent issue for all that is here: And the one relating to buttons is here: Thanks! |
@mlissner I've been reviewing the issue to see what's still on our plate. I took a moment to mark as done some items @v-anne added in the last PR(thanks so much! :)) I was also thinking about the best spot for the "Your Prayers" button. You suggested a design similar to the new one on the opinion page, which sounds great. I think a really user-friendly location for this button (especially for those who use alerts and notes) would be in the profile dropdown menu. What do you think? |
@v-anne I just noticed you opened another PR today and was wondering if you plan to address point 3 as well? (No worries if not, just curious!) |
Thanks @ERosendo, I was planning to work on the remainder of 5 first. I like your button placement, but I think the button should be on both the profile dropdown and where Mike suggested it. I don't see any harm in having it in two places. I was planning to work on the modal last because I think there is some sort of issue with the existing API as I flagged earlier in the thread. I wanted to squash that potential bug while adding the modal, but happy to defer to you if you prefer to go ahead. |
@v-anne sorry, I didn't mean to make it sound like an either/or situation. I think adding it to the top prayers page is a great idea. I just wanted to suggest that we should consider including it in the dropdown menu as well. |
Sounds good, I just added it to the dropdown. I think we need to figure out what icon to use for this, like the bell for the alerts and a tag for the tags. |
Also re: 8, I think pagination can hold off until the feature has launched. That's because the function to get top requests is capped at 50 documents anyway, and it's unlikely any user will have a ton of requests to spread over multiple pages for the time being. |
@v-anne I've been testing the endpoint and the docket page, but I wasn't able to reproduce the issue you're describing. Here's a short GIF showing the steps I took during my testing: It's not shown in the GIF, but after creating the prayer using the API, I refreshed the docket page to update the prayer counts. Did you do something different? Or were you expecting the docket page to automatically update with the new counts after using the API without needing to refresh? |
The icon should be the prayer hands, I think, right? I don't see that in font awesome though, unfortunately.
That's fine. It's pretty easy to add, but we can wait until it's a problem (but that won't be long!). |
@mlissner, I'm looking into the mailing list next. Should I do the same thing as the prayer alert emails, i.e., create html and .txt templates? How do I create the mailing list itself? Do I need a new Django model that adds users to the list or is there an existing model that keeps track of mailing lists sitewide? |
It's actually easier than that. @jeniferw will give us a link and she'll automate the rest through our email/donor platform. |
It's getting really close. Thanks everybody for the work getting it so far. It's cool already, but we need the UX to be good for it to work. I hope this doesn't feel like moving goalposts. We're close!
Here are my thoughts for the next round:
DONE: From the leader board, clicking on documents that aren't on page 1 of the docket doesn't work. For example, this link fails because the docket page only goes to entry 159 (and the link is for number 396):
https://www.courtlistener.com/docket/63290154/missouri-v-biden/#entry-396
A simple solution is to take the users to the document page instead:
https://www.courtlistener.com/docket/63290154/396/missouri-v-biden/
DONE: Speaking of those pages, I just noticed they don't have the icon. Darn.
We still need to teach people what the emojis mean and how to find the prayer leader board. One thought is that the first time somebody prays for something, we could pop up a modal congratulates them on their first prayer and then tells them about the leaderboard, how it all works, and points them to the help page.
We'd need a reliable way to know if the prayer was somebody's first. Maybe the API for creating a prayer could efficiently return if it's the first one the user has?
We're going to set up an email list that reminds people to buy things with their PACER accounts at the end of each quarter. We'll just need a button for it so people can go to the sign up page, and we'll want that button on our help page with an explanation there too.
The leader board page:
h1
heading on the leader board needs space below it. Maybe add.v-offset-below-3
to it?As for where the buttons should go, I think it should mimic our new opinion page. It's not yet released, but it looks like this across the top:
I think the Remind Me to Help button can go on the left, and the "Your Prayers" and "Learn More" can go on the right. All buttons can be white.
DONE: The HTML title for this page should say:
The og:description needs filling out too. It can explain a bit about what the project is.
DONE: The "Your Requests" page:
.v-offset-below-3
class.og:description
updated to give more details again (imagine sharing the link in Slack).We need pagination on both of these pages. Maybe 25 items each?
In #4507 (comment), @v-anne suggested:
I'm actually sort of curious how useful this table will be to folks. I guess people might use it as a bookmark for stuff they're interested in, so this suggestion would be helpful. I think it's OK to punt on this for now though and keep the page simple.
Super interesting. We do that on the user tags page. I feel like for this to work, the page will need an RSS feed for people to follow or something. Just expecting people to reload it seems unlikely to do much. I suggest punting this for now too.
Some docket entries lack entry numbers. That'd be an easy thing to key off of. I'm not sure if we know how to detect minute entries though.
I think these are my
wishesprayers for the last iteration. I'm going to push a branch with help file tune up too in a few minutes.Thank you all for pushing and pushing this feature. It's one of the bigger ones that has been volunteer-contributed in a long time.
The text was updated successfully, but these errors were encountered: