Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source package does not include data #33

Open
step21 opened this issue Oct 10, 2021 · 4 comments
Open

source package does not include data #33

step21 opened this issue Oct 10, 2021 · 4 comments
Assignees

Comments

@step21
Copy link
Contributor

step21 commented Oct 10, 2021

While trying to make a conda package - I found out that the source package does not include the data, and thus cannot be used successfully. Ideally, I think the data (json files) should be included. At least in the source package I also did not find a way to generate this data. (such as courts_db/data/*.json)

@step21
Copy link
Contributor Author

step21 commented Oct 10, 2021

according to this the package_data specified in setup.py only works for binary dists, whereas Manifest.in works for both.

@mlissner
Copy link
Member

@flooie can you take a look at this? I just looked through all of the versions of courts-db that have ever been on PyPi and none of them include the actual court data. Seems like it's possible we never installed the package and nobody else did either? Maybe they did but gave up?

@mlissner mlissner reopened this Oct 13, 2021
@mlissner
Copy link
Member

See also: #35

@step21
Copy link
Contributor Author

step21 commented Oct 14, 2021

What is more likely in my opinion, they just installed the wheel (*.whl) which does seem to contain them. It is just a zip file with another extension. Most of the time there is no need for the source distribution because courts-db doesn't contain compiled files afaik, so they just used that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants