From 0e94b125e256980e6e186338ca53cf1813a7b995 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 09:39:55 -0500 Subject: [PATCH 1/8] Fix missng env var and update to use local instead of dev to correctly handle the info for parachains --- .github/workflows/release.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d03c8c4d4b..60ae6ad4cf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -513,8 +513,8 @@ jobs: runs-on: ubuntu-22.04 env: BIN_DIR: target/release - BIN_FILENAME: frequency-dev.amd64 - TEST_BIN_FILENAME: frequency-dev.amd64 + BIN_FILENAME: frequency-local.amd64 + TEST_BIN_FILENAME: frequency-local.amd64 TEST_DOWNLOAD_DIR: download-test REF_BIN_FILENAME: frequency-ref.amd64 REF_DOWNLOAD_DIR: download-ref @@ -544,7 +544,7 @@ jobs: id: download-binaries uses: actions/download-artifact@v4 with: - pattern: artifacts-binary-${{env.NETWORK}}-${{github.run_id}} + pattern: artifacts-binary-local-${{github.run_id}} path: ${{env.TEST_DOWNLOAD_DIR}} - name: Rename and Move Binaries run: | From 98f972291db180738a460c12c53e5044a51550d3 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 10:26:46 -0500 Subject: [PATCH 2/8] Fix test binary name --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 60ae6ad4cf..39ad1fd62b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -554,7 +554,7 @@ jobs: echo "Downloaded binaries: $(ls -l $download_dir)" mkdir -p ${{env.BIN_DIR}} mv ${{env.REF_DOWNLOAD_DIR}}/${{env.BIN_FILENAME}} ${{env.BIN_DIR}}/${{env.REF_BIN_FILENAME}} - mv ${{env.TEST_DOWNLOAD_DIR}}/${{env.BIN_FILENAME}} ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}} + mv ${{env.TEST_DOWNLOAD_DIR}}/artifacts-binary-local-${{github.run_id}} ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}} - name: Set Binary Permissions working-directory: ${{env.BIN_DIR}} run: | From e0266bc074e0143d5f1c81168820cd68c2993335 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 11:39:19 -0500 Subject: [PATCH 3/8] Fix test binary folder --- .github/workflows/release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 39ad1fd62b..ab66025212 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -554,12 +554,14 @@ jobs: echo "Downloaded binaries: $(ls -l $download_dir)" mkdir -p ${{env.BIN_DIR}} mv ${{env.REF_DOWNLOAD_DIR}}/${{env.BIN_FILENAME}} ${{env.BIN_DIR}}/${{env.REF_BIN_FILENAME}} - mv ${{env.TEST_DOWNLOAD_DIR}}/artifacts-binary-local-${{github.run_id}} ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}} + mv "${download_dir}/${{env.BIN_FILENAME}}" ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}} - name: Set Binary Permissions working-directory: ${{env.BIN_DIR}} run: | chmod 755 $TEST_BIN_FILENAME chmod 755 $REF_BIN_FILENAME + echo "Binary Directory:" + ls -la ./ - name: Docker network run: docker network create net-${{env.RELEASE_BRANCH_NAME}} - name: Start Test Node From b1dcb4161549b78cd6cdf953c79568a102229121 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 12:27:48 -0500 Subject: [PATCH 4/8] Fix chain reference --- .github/workflows/release.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ab66025212..dcce99ebbd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -572,7 +572,6 @@ jobs: --name test-node \ ubuntu:24.04 \ /bin/sh -c "chmod +x /app/${{env.TEST_BIN_FILENAME}} && /app/${{env.TEST_BIN_FILENAME}} \ - --chain=dev \ --rpc-external \ --rpc-cors=all \ --rpc-methods=Unsafe \ @@ -592,7 +591,6 @@ jobs: --name ref-node \ ubuntu:24.04 \ /bin/sh -c "chmod +x /app/${{env.REF_BIN_FILENAME}} && /app/${{env.REF_BIN_FILENAME}} \ - --chain=dev \ --rpc-external \ --rpc-cors=all \ --rpc-methods=Unsafe \ From c45eb7894ed4bd22881fe580278e5140d8c0d50e Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 13:32:38 -0500 Subject: [PATCH 5/8] Switch from local to dev --- .github/workflows/release.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index dcce99ebbd..1da5a40c13 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -513,8 +513,8 @@ jobs: runs-on: ubuntu-22.04 env: BIN_DIR: target/release - BIN_FILENAME: frequency-local.amd64 - TEST_BIN_FILENAME: frequency-local.amd64 + BIN_FILENAME: frequency-dev.amd64 + TEST_BIN_FILENAME: frequency-dev.amd64 TEST_DOWNLOAD_DIR: download-test REF_BIN_FILENAME: frequency-ref.amd64 REF_DOWNLOAD_DIR: download-ref @@ -544,7 +544,7 @@ jobs: id: download-binaries uses: actions/download-artifact@v4 with: - pattern: artifacts-binary-local-${{github.run_id}} + pattern: artifacts-binary-dev-${{github.run_id}} path: ${{env.TEST_DOWNLOAD_DIR}} - name: Rename and Move Binaries run: | @@ -632,7 +632,7 @@ jobs: name: artifacts-metadata-${{github.run_id}} path: ${{env.OUTPUT_DIR}}/${{env.OUTPUT_FILENAME}} if-no-files-found: error - - name: Stop Local Nodes + - name: Stop Nodes if: always() run: | echo "Attempting to kill all frequency processes..." From a7ced44d21c72e01921b84e83093d47d5d52f5b8 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 14:53:57 -0500 Subject: [PATCH 6/8] REVERT ME: Test against v1.15.0 tag --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1da5a40c13..af1e975d38 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -533,7 +533,7 @@ jobs: id: get-previous-full-release-version uses: ./.github/workflows/common/get-previous-full-release-version with: - full-release-version-tag: ${{env.LATEST_FULL_RELEASE_TAG}} + full-release-version-tag: v1.15.0 - name: Fetch Reference Binary uses: robinraju/release-downloader@a96f54c1b5f5e09e47d9504526e96febd949d4c2 with: From 85beba35c4564e54fa6879ad6d2f23a16b8153b2 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 14:54:13 -0500 Subject: [PATCH 7/8] Revert "Switch from local to dev" This reverts commit c45eb7894ed4bd22881fe580278e5140d8c0d50e. --- .github/workflows/release.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index af1e975d38..9043b3c5b2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -513,8 +513,8 @@ jobs: runs-on: ubuntu-22.04 env: BIN_DIR: target/release - BIN_FILENAME: frequency-dev.amd64 - TEST_BIN_FILENAME: frequency-dev.amd64 + BIN_FILENAME: frequency-local.amd64 + TEST_BIN_FILENAME: frequency-local.amd64 TEST_DOWNLOAD_DIR: download-test REF_BIN_FILENAME: frequency-ref.amd64 REF_DOWNLOAD_DIR: download-ref @@ -544,7 +544,7 @@ jobs: id: download-binaries uses: actions/download-artifact@v4 with: - pattern: artifacts-binary-dev-${{github.run_id}} + pattern: artifacts-binary-local-${{github.run_id}} path: ${{env.TEST_DOWNLOAD_DIR}} - name: Rename and Move Binaries run: | @@ -632,7 +632,7 @@ jobs: name: artifacts-metadata-${{github.run_id}} path: ${{env.OUTPUT_DIR}}/${{env.OUTPUT_FILENAME}} if-no-files-found: error - - name: Stop Nodes + - name: Stop Local Nodes if: always() run: | echo "Attempting to kill all frequency processes..." From 000711c9c34f3f4f96b42f031ec5b97a2bebf734 Mon Sep 17 00:00:00 2001 From: Wil Wade Date: Mon, 6 Jan 2025 16:04:48 -0500 Subject: [PATCH 8/8] Revert "REVERT ME: Test against v1.15.0 tag" This reverts commit a7ced44d21c72e01921b84e83093d47d5d52f5b8. --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9043b3c5b2..dcce99ebbd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -533,7 +533,7 @@ jobs: id: get-previous-full-release-version uses: ./.github/workflows/common/get-previous-full-release-version with: - full-release-version-tag: v1.15.0 + full-release-version-tag: ${{env.LATEST_FULL_RELEASE_TAG}} - name: Fetch Reference Binary uses: robinraju/release-downloader@a96f54c1b5f5e09e47d9504526e96febd949d4c2 with: