Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stake to provider #87

Closed
Tracked by #81
claireolmstead opened this issue Jan 12, 2024 · 10 comments
Closed
Tracked by #81

Stake to provider #87

claireolmstead opened this issue Jan 12, 2024 · 10 comments
Assignees
Labels

Comments

@claireolmstead
Copy link
Contributor

claireolmstead commented Jan 12, 2024

Image

Acceptance Criteria

  • Should act like our standard modal
@rlaferla
Copy link
Contributor

rlaferla commented Feb 2, 2024

Question:
The title "Amount in Unit" is that literal or is the unit dynamic? e.g. "Amount in XRQCY"

@rlaferla
Copy link
Contributor

rlaferla commented Feb 2, 2024

Question:

Which keys can the user stake from? 1. Any key? 2. Any key associated with a MSA? 3. Any provider key? 4. Only the key the user is signed in as? 5. Other

@rlaferla
Copy link
Contributor

rlaferla commented Feb 5, 2024

@wilwade ☝🏻

@wilwade
Copy link
Contributor

wilwade commented Feb 5, 2024

@rlaferla

Which keys can the user stake from? 1. Any key? 2. Any key associated with a MSA? 3. Any provider key? 4. Only the key the user is signed in as? 5. Other

Any key.

@rlaferla
Copy link
Contributor

rlaferla commented Feb 5, 2024

In addition to my previous comment, should the unit in the requirements section be updated dynamically: "1. Ensure the control key has a FRQCY balance."?

@wilwade
Copy link
Contributor

wilwade commented Feb 5, 2024

It already is, so it should remain so.

@rlaferla
Copy link
Contributor

rlaferla commented Feb 5, 2024

It is already hard-coded? Please clarify because from what I see in the source code, it's hard-coded:

<ol class="ml-4 mt-4 list-decimal font-light">
      <li>Ensure the control key has a FRQCY balance.</li>
      <li>Click 'Stake'</li>
      <li>This will require 1 signature to send the transaction.</li>
</ol>

@wilwade
Copy link
Contributor

wilwade commented Feb 5, 2024

Rococo:
image

Localhost:
image

@rlaferla
Copy link
Contributor

rlaferla commented Feb 5, 2024

I changed the help text to now match the title. i.e. both are now dynamic.

@claireolmstead claireolmstead self-assigned this Feb 8, 2024
@wilwade
Copy link
Contributor

wilwade commented Mar 20, 2024

Complete!

@wilwade wilwade closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants