Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image optimalisation adapter #69

Open
martinbroos opened this issue Sep 22, 2020 · 1 comment
Open

Image optimalisation adapter #69

martinbroos opened this issue Sep 22, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@martinbroos
Copy link
Member

Images (svg/png/jpg) need optimalisation to ensure that meta data is stripped and quality matches web standards. This way the end user does not load images that are too big.
SVG needs cleaning code to optimize.

There is a plugin to do this, would be nice if we could add this to adapter to make it easier to implement with all the best settings set. Also we could a test that it is loaded after copy webpack plugin to ensure these images are also optimized.

https://www.npmjs.com/package/imagemin-webpack

Is this something that would be worth adding ?

@martinbroos martinbroos added the enhancement New feature or request label Sep 22, 2020
@martinbroos
Copy link
Member Author

De eenvoudigste implementatie lijkt me met een minimizer voor webpack: https://webpack.js.org/plugins/image-minimizer-webpack-plugin/

Ik zou dit alleen niet snel onderdeel maken van de default stack gezien de dependencies die erbij komen kijken en je vaak toch maar enkele afbeeldingen in je assets hebt zitten. Een adapter zou iemand wel kunnen helpen om het snel is zijn project te zetten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant