-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization tokens force a non-blank username #289
Comments
Hi. Thanks for opening an issue about this. I agree with you. It's probably best to make both fields optional. We could show a warning, but I'm not even sure if that's necessary. Do you know how an empty username/password looks like in the header? Are they just treated as empty strings?
|
Oh yeah, the empty password case works exactly like that at the moment. So I assume the empty username case will work the same way. |
Yeah, empty strings. The colon is always included so it can be decoded and tokenised by standard tools. |
I uploaded version 4.4.0, which makes the username optional. Should be available in the next hours. Thanks again for reporting. |
I know APIs exist where the user must be blank and only the password is used to identify and authenticate the user. I would assume that there also exist some that are the converse (empty pass + token in username). Disallowing the empty string seems like an unnecessary restriction, and would be better handled with a warning to confirm upon save.
The text was updated successfully, but these errors were encountered: