Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scour to pipeline #397

Open
KjellMorgenstern opened this issue Sep 5, 2024 · 2 comments
Open

Add scour to pipeline #397

KjellMorgenstern opened this issue Sep 5, 2024 · 2 comments

Comments

@KjellMorgenstern
Copy link
Member

For nearly all recents parts I added or modified, I applied scour (https://github.com/scour-project/scour) to minimize, clean und unify the SVG files.

It would make sense to add this to our pipeline.

@KjellMorgenstern
Copy link
Member Author

KjellMorgenstern commented Sep 5, 2024

Suggestion:

Typically, we can't modify the files during the CI this would require an new commit.
We could run scour on each SVG with some sane settings.
If the file changes, then the check fails with an error message, with a link to some place that explains how to use scour in fritzing SVG files.

I don't think scour is intended to be used as a check. There could be changes when running on the same file a second time, or between different environments or versions of scour.

@mMerlin
Copy link
Contributor

mMerlin commented Sep 5, 2024

Perhaps it can be added to 'pre-commit' instead. I think that allows content changes. CircuitPython has that on their libraries, to enforce some linting.

I don't know about additional runs with the same parameters making additional changes. That could be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants