From 79fc8d19a2502e20dd6ece6004a1a35f6e9bfb2a Mon Sep 17 00:00:00 2001 From: Matthias Dittrich Date: Sat, 12 Jan 2019 15:23:01 +0100 Subject: [PATCH] Release notes and documentation for `Options.Create` /cc @severisv --- RELEASE_NOTES.md | 8 ++++++-- src/app/Fake.DotNet.Cli/DotNet.fs | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 289c7b9a8ec..bf73b8e9864 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,8 +1,12 @@ # Release Notes -## 5.11.2-alpha - tbd +## 5.12.0 - 2019-01-12 -* tbd +* NEW: module `Fake.DotNet.Xdt` - https://github.com/fsharp/FAKE/pull/2218 +* IMPROVEMENT: DotNet take version into account when determining dotnet cli path - https://github.com/fsharp/FAKE/pull/2220 + Usages of the `DotNet` might yield different results than what you would get in the command line to ensure the given version is used. +* DOCUMENTATION: `StreamSpecification` doc improvements - https://github.com/fsharp/FAKE/pull/2222 +* DOCUMENTATION: Various improvements to the contributors guide - https://github.com/fsharp/FAKE/pull/2232 ## 5.11.1 - 2018-12-07 diff --git a/src/app/Fake.DotNet.Cli/DotNet.fs b/src/app/Fake.DotNet.Cli/DotNet.fs index da2bd3e00a8..8a01002e88a 100644 --- a/src/app/Fake.DotNet.Cli/DotNet.fs +++ b/src/app/Fake.DotNet.Cli/DotNet.fs @@ -80,7 +80,7 @@ module DotNet = let private findPossibleDotnetCliPaths dotnetCliDir = seq { let fileName = if Environment.isUnix then "dotnet" else "dotnet.exe" yield! - Process.findFilesOnPath "dotnet" + ProcessUtils.findFilesOnPath "dotnet" |> Seq.filter File.Exists let userInstalldir = defaultUserInstallDir fileName if File.exists userInstalldir then yield userInstalldir @@ -499,6 +499,10 @@ module DotNet = /// NOTE: This field is ignored when UseShellExecute is true. Environment : Map } + + /// Create a default setup for executing the `dotnet` command line. + /// This function tries to take current `global.json` into account and tries to find the correct installation. + /// To overwrite this behavior set `DotNetCliPath` manually (for example to the first result of `ProcessUtils.findFilesOnPath "dotnet"`) static member Create() = { DotNetCliPath = let version = tryGetSDKVersionFromGlobalJson()