Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1905 breaks on Unix because of backslash #2020

Closed
sliepie opened this issue Jul 10, 2018 · 0 comments
Closed

#1905 breaks on Unix because of backslash #2020

sliepie opened this issue Jul 10, 2018 · 0 comments

Comments

@sliepie
Copy link
Contributor

sliepie commented Jul 10, 2018

In #1905 a backslash is added when the output param is set, as a fix for #896
Unfortunateley this breaks on Unix, as it expects a / rather than a \

@theimowski writes in 1905:

This seems to break older versions of mono, for
XBuild Engine Version 14.0
Mono, Version 4.6.1.0

xbuild tries to copy assemblies to a path with a backslash:

Copying file from '$BUILD_DIR/packages/NUnit/lib/nunit.framework.dll' to '$BUILD_DIR/test\nunit.framework.dll'

and fails to do so because that's a unix box.

We should detect if we're running on a Windows or a unix and and the correct slash to the end.

@sliepie sliepie mentioned this issue Jul 10, 2018
matthid added a commit that referenced this issue Jul 21, 2018
Fix #2020 add slash instead of backslash on a non windows platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant