quote project parameters in dotnet module

[kblohm]

fixes #2052

[matthid]

I'm not sure if quoteIfNeeded is correct. It looks broken to me. Should we fix that here or use one of the new apis?

[kblohm]

That is the one used in the MsBuild-Module (and probably all over the place). Where can i find a version that is not broken?

[matthid]

https://github.com/fsharp/FAKE/blob/release/next/src/app/Fake.Core.Process/CmdLineParsing.fs are the new apis for escaping arguments they conform to the spec. We always use the "windows" escaping (even on linux) as that's what they have implemented in netcore.

[matthid]

Also I'm not even sure why quoteIfNeeded actually exists, why not just always escape properly?

[kblohm]

I have no idea. Maybe unescaped arguments look better? ;)

[matthid]

I guess it's historic because we never had proper escaping and unquoted worked cross platform

[matthid]

Additionally, if we decide there is an advantage of not using quotes (and proper escaping) we should add it to the new API which will make them nicer everywhere :)

[matthid]

Or leave it like this I think I'll just update quote and quoteIfNeeded and see what happens on next release

[kblohm]

Update it to delegate to the new API?

[matthid]

109ec13

[matthid]

Thanks!