Porting DotCover module #2058
Porting DotCover module #2058
Conversation
change obsolete description
Not really, but somehow it looks wrong ;) Would it be enough to add another public API to those modules with the following signature: let buildArgs (setDotCoverParams: DotCoverParams -> DotCoverParams) : string =
// ...? |
|
It is not sufficient, because those |
|
I think that having Maybe with |
|
Ah yes, sorry this is actually what I meant... Basically we can make these things public as you suggest in the PR but we should make this a "feature" and unify the signatures (just like we did for
I'm not 100% sure about this because sometimes it can be used for unblocking people, the disadvantage is that there is less need to contribute back ;) |
| | NDependXml = 3 | ||
|
|
||
| /// The dotCover parameter type for running coverage | ||
| [<CLIMutable>] |
| CustomParameters = "" | ||
| ErrorLevel = ErrorLevel.Error} | ||
|
|
||
| [<CLIMutable>] |
| TempDir = "" | ||
| CustomParameters = "" } | ||
|
|
||
| [<CLIMutable>] |
| /// ## Parameters | ||
| /// | ||
| /// - `setParams` - Function used to overwrite the dotCover default parameters. | ||
| let DotCover (setParams: DotCoverParams -> DotCoverParams) = |
There was a problem hiding this comment.
Can we rename this to run as other modules?
| /// Source = artifactsDir @@ "dotCoverSnapshot.dcvr" | ||
| /// Output = artifactsDir @@ "dotCoverReport.xml" | ||
| /// ReportType = DotCoverReportType.Xml }) | ||
| let DotCoverReport (setParams: DotCoverReportParams -> DotCoverReportParams) = |
| /// Output = artifactsDir @@ "NUnitDotCoverSnapshot.dcvr" }) | ||
| /// (fun nUnitOptions -> { nUnitOptions with | ||
| /// DisableShadowCopy = true }) | ||
| let DotCoverNUnit (setDotCoverParams: DotCoverParams -> DotCoverParams) (setNUnitParams: NUnit.Common.NUnitParams -> NUnit.Common.NUnitParams) (assemblies: string seq) = |
|
Sorry for the late review |
|
|
@matthid Any suggestion with those
internal buildXXXXArgsfrom other modules which are used in DotCover?