Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squirrel for FAKE v5 #2076

Merged
merged 4 commits into from
Sep 8, 2018
Merged

Squirrel for FAKE v5 #2076

merged 4 commits into from
Sep 8, 2018

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Sep 5, 2018 •
edited
Loading

Description

Port Squirrel helper to FAKE v5

TODO

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • unit or integration test exists (or short reasoning why it doesn't make sense) The previous tests were essentially testing string concatenation... I don't see any interest in porting that
  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.
  • (if new module) the module is in the correct namespace
  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)
  • Fake 5 API guideline is honored

matthid
matthid reviewed Sep 5, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some small issues :)

@kblohm
Copy link
Contributor

kblohm commented Sep 5, 2018

Small note: as this is an installer, would you mind putting it into the Fake.Installer namespace?
Thats where both WiX and InnoSetup reside.

@vbfox
Copy link
Contributor Author

vbfox commented Sep 5, 2018

New take

  • Inverted parameters
  • Fixed doc
  • Moved namespace
  • Fixed SLN

Maybe new problems !

matthid
matthid reviewed Sep 7, 2018
View reviewed changes
matthid
matthid approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@matthid matthid merged commit 1bfd0d0 into fsprojects:release/next Sep 8, 2018
@matthid matthid changed the title Squirell for FAKE v5 Squirrel for FAKE v5 Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblohm kblohm kblohm left review comments

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbfox @kblohm @matthid