Enhanced TeamCity Logging #2111
Conversation
… into TeamCityLogging
| @@ -394,10 +403,15 @@ module TeamCity = | |||
| match description with | |||
| | Some d -> TeamCityWriter.sendOpenBlock tag.Name (sprintf "%s: %s" tag.Type d) | |||
| | _ -> TeamCityWriter.sendOpenBlock tag.Name tag.Type | |||
| | TraceData.CloseTag (tag, _, status) when status = TagStatus.Failed -> | |||
There was a problem hiding this comment.
| TraceData.CloseTag (tag, _, TagStatus.Failed)?
There was a problem hiding this comment.
Wait...that's a thing...
|
@matthid this all good now? |
| @@ -39,11 +39,13 @@ module TeamCityImportExtensions = | |||
| /// The general documentation on how to use CI server integration can be found [here](/buildserver.html). | |||
| /// This module does not provide any special APIs please use FAKE APIs and they should integrate into this CI server. | |||
| /// If some integration is not working as expected or you have features you would like to use directly please open an issue. | |||
| /// | |||
| /// For more information on TeamCity interaction from builc scripts [see here](https://confluence.jetbrains.com/display/TCD18/Build+Script+Interaction+with+TeamCity) | |||
There was a problem hiding this comment.
I'd assume more important would be how to set the "fail on traceError flag" and how fake in particular interacts with TeamCity. I don't think just the link to teamcity docs helps fake users here.
I'd love to see another PR to improve the docs but I'm not blocking this one
| else | ||
| alignedError "Status:" "Failure" null | ||
| Trace.setBuildState TagStatus.Failed |
There was a problem hiding this comment.
@BlythMeister Is there any particular reason why we need that? I'm asking because I just realized (after trying to figure out for hours which commit is to blame) that this makes the VSTS build red. This is because we have some testing going on with negative/failing cases which will call this API and make the build red.
There was a problem hiding this comment.
The reason is so that when running on a CI (like teamcity) when the build fails the state is set to failure.
It's to try and prevent the build failure ending with "Process returned exit code 1"
There was a problem hiding this comment.
But shouldn't that Process returned exit code 1 already be solved by using the error apis?
There was a problem hiding this comment.
possibly...happy to revert this bit of the change and try
There was a problem hiding this comment.
It does mean though that any listener with "TraceData.BuildState" is a bit pointless as nothing ever traces with that...
There was a problem hiding this comment.
How about we make it so there is a new run or update existing runs to return the TargetContext from runInternal
That way, as a user you can make the decision to react to the overall run result...
There was a problem hiding this comment.
(facepalm)....a bit like runAndGetContext
I'll shut up :)
There was a problem hiding this comment.
match context.PreviousTargets.Length, context.HasError with
| 0, _ -> Trace.setBuildState TagStatus.Warning
| _, true -> Trace.setBuildState TagStatus.Failed
| _, _ -> Trace.setBuildState TagStatus.Success
in my script after calling runAndGetContext means it does what i want :)
There was a problem hiding this comment.
Yes I should have been a bit more conservative with these changes... Found another edge case where the build went red in teamcity (good that we have a teamcity build now) so I need a bit more time to release this properly.
Regarding your suggestion. Yes indeed we could make that an opt-in api:
let context = Target.tryRunOrDefaultAndGetContext "Default"
Target.reportBuildStateFromContext context(Or something along those lines)
Can you open a PR or an issue for this (so it is not forgotten in this PR)
There was a problem hiding this comment.
I'll take a look next week and ensure that all run methods also have a WithContext
and add a function to report status based on context which you could (and I will) pipe the run into.
Watch this space 😂
Description
Superseeds: #2109
Fixes #2108
Update TeamCity listener to match the documentation for service messages
Add functionality in the targets to report build state through trace