You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in PR #32, the notebook output needs to be updated, but there were a couple of issues, as stated in a comment to the PR:
The issues I noticed were that the UPath untested default warning appears, which we may want to filter or suppress, since this notebook is the primary user documentation. Also, the readme.exists() cell is now returning False, so it looks like something somewhere may have broken, although I don't think it is in this PR, I tested on main and the issue still happens, so I will create an issue to address that.
In addition to those issues, I think it would be worth clarifying this point:
Some filesystems may require extra imports to use.
Since fsspec tries to instantiate registered implementations as needed, I think it would be more clear to state something like:
Some filesystems may require additional packages to be installed.
The import of s3fs is not necessary and may cause confusion about whether target filesystem packages need to be imported prior to usage with UPath.
One idea I had is that it might be a handy reference to import and cleanly print the known fsspec implementations at the end of the notebook.
I'd be interested in any feedback. Hopefully I'll be able to submit another PR sometime soon with some of these changes.
The text was updated successfully, but these errors were encountered:
@andrewfulton9,
As mentioned in PR #32, the notebook output needs to be updated, but there were a couple of issues, as stated in a comment to the PR:
In addition to those issues, I think it would be worth clarifying this point:
Since fsspec tries to instantiate registered implementations as needed, I think it would be more clear to state something like:
The import of
s3fs
is not necessary and may cause confusion about whether target filesystem packages need to be imported prior to usage with UPath.One idea I had is that it might be a handy reference to import and cleanly print the known fsspec implementations at the end of the notebook.
I'd be interested in any feedback. Hopefully I'll be able to submit another PR sometime soon with some of these changes.
The text was updated successfully, but these errors were encountered: