-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Allow use for s3 instead of dynamodb. #143
Comments
Seems like there at least is an opportunity to refactor the dynamodb dependency so that the datasource is more modularized. If credstash is referencing a datasource interface, with a dynamodb implementation of that interface, then it would be more straight forward in the future to add new data persistence options. Currently the dependency between dynamodb and credstash is pretty pervasive. |
@LeeAdcock I've done the modularisation already in my fork (https://github.com/3stack-software/credsmash) I just need to upstream it...
|
I would also like to see this happen. We're looking at using aurora instead of dynamodb for pricing/performance concerns. |
there is a PR for that: #139 |
i do not know if this is still "really" open, but dynamo does support the usage of kms and you can create cross-region clusters to replicate secrets. |
dynamodb currently does not support encryption at rest, as well as support for vpc endpoints. In order for a completely secure solution, we would need to add support for credstash to pull files from s3 which store credentials.
The text was updated successfully, but these errors were encountered: