Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow use for s3 instead of dynamodb. #143

Open
willcrain1 opened this issue Mar 13, 2017 · 5 comments
Open

Enhancement: Allow use for s3 instead of dynamodb. #143

willcrain1 opened this issue Mar 13, 2017 · 5 comments

Comments

@willcrain1
Copy link

dynamodb currently does not support encryption at rest, as well as support for vpc endpoints. In order for a completely secure solution, we would need to add support for credstash to pull files from s3 which store credentials.

@LeeAdcock
Copy link

Seems like there at least is an opportunity to refactor the dynamodb dependency so that the datasource is more modularized. If credstash is referencing a datasource interface, with a dynamodb implementation of that interface, then it would be more straight forward in the future to add new data persistence options. Currently the dependency between dynamodb and credstash is pretty pervasive.

@nathan-muir
Copy link
Contributor

nathan-muir commented Mar 13, 2017

@LeeAdcock I've done the modularisation already in my fork (https://github.com/3stack-software/credsmash) I just need to upstream it...

  1. You can create another package with the entry point credsmash.storage_service
  2. Set the storage_service option in the config to the name of your entry point.
    (There's an example config in the bottom of https://github.com/3stack-software/credsmash/blob/master/HISTORY.md)

@ajmath
Copy link

ajmath commented Apr 4, 2017

I would also like to see this happen. We're looking at using aurora instead of dynamodb for pricing/performance concerns.

@sebastianreloaded
Copy link

there is a PR for that: #139

@rkgyellowjacket
Copy link

i do not know if this is still "really" open, but dynamo does support the usage of kms and you can create cross-region clusters to replicate secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants