You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the invokeServerStream function does not properly check the err on line 265.
This (can) cause a nil panic if the method is not implemented (or another error occurs) on line 267's str.Header().
Update: Interestingly I'm only seeing this behavior when using github.com/fullstorydev/grpchan. I'm still investigating but I think before a PR is opened the question needs to be asked as to which the proper behavior is. That is to say: How should a Streaming service note that it's not implemented?
This isn't a huge deal as I immediately plan on implementing this service but it was a fun rabbit hole to go down so far, so I'll keep investigating before opening a PR.
I believe this is as simple as following the pattern used in the invokeUnary function above and am preparing a PR.
I believe the
invokeServerStream
function does not properly check theerr
on line 265.This (can) cause a nil panic if the method is not implemented (or another error occurs) on line 267's
str.Header()
.Update: Interestingly I'm only seeing this behavior when using
github.com/fullstorydev/grpchan
. I'm still investigating but I think before a PR is opened the question needs to be asked as to which the proper behavior is. That is to say: How should a Streaming service note that it's not implemented?This isn't a huge deal as I immediately plan on implementing this service but it was a fun rabbit hole to go down so far, so I'll keep investigating before opening a PR.
I believe this is as simple as following the pattern used in theinvokeUnary
function above and am preparing a PR.Here is an example (trimmed) trace:
Thanks so much for this great library!
The text was updated successfully, but these errors were encountered: