feat: local support for presigned url #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
approved these changes
Oct 30, 2023
Comment on lines
202
to
204
| const body = req.body | ||
| ? JSON.stringify(req.body) | ||
| : await getBody(req); |
There was a problem hiding this comment.
This looks weird. Why are you stringifying the body?
Also, when I hacked around this, I had to be careful about handling OPTIONS pre-flight requests when calling put on the front end.
There was a problem hiding this comment.
Ohh, yeah, OPTIONS is a good point. I think I'll just need to let unhandled methods pass through to the normal handler.
I was stringifying here because this logic was originally AFTER the JSON body parser, but now it is before so I can remove this logic.
| }; | ||
| } | ||
|
|
||
| public decodeAsyncUrlKey( |
There was a problem hiding this comment.
I don't understand the name "decode async url key"
There was a problem hiding this comment.
lol, I let the AI name this and forgot to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341