Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateContainerOptions has i_ops and cp_us instead of iops and cpus #408

Closed
paul-hansen opened this issue May 11, 2024 · 2 comments · Fixed by #410
Closed

UpdateContainerOptions has i_ops and cp_us instead of iops and cpus #408

paul-hansen opened this issue May 11, 2024 · 2 comments · Fixed by #410
Labels
bug Something isn't working

Comments

@paul-hansen
Copy link
Contributor

Very minor thing, but in UpdateContainerOptions i_ops and cp_us has an underscore in the wrong place compared to HostConfig which has them as iops and cpus.

Seems to be the only on UpdateContainerOptions:
https://docs.rs/bollard/0.16.1?search=i_ops
https://docs.rs/bollard/0.16.1?search=cp_us

I'm hoping this is a super easy fix for someone as I'm not setup for Java dev to work on the codegen, but I might try it if no one picks it up.

Thanks for this library, it's been great!

@fussybeaver fussybeaver added the bug Something isn't working label May 12, 2024
@fussybeaver
Copy link
Owner

Thanks, the input parameters (so all the *Options structs) are not governed by the swagger API documentation, so we can just edit those directly in src/container.rs.

@paul-hansen
Copy link
Contributor Author

paul-hansen commented May 12, 2024

Oh nice! Knowing that, I tried to do this in #410

I went ahead and updated a couple other things on that struct too after reviewing docker's API (see PR description). I think they all make sense but lmk if any of that shouldn't have been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants