Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #554 - Switch toggle functionality Issue, Fixes #555 - Notification working after quick async operation, Enhancement #556 - Added width prop for Table, Fixes #557 - Fix alignment between text and icon of Top bar #559

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dev-shivang
Copy link
Collaborator

Description

The PR addresses multiple bug fixes and enhancements related to UI functionality and alignment issues in the project. Here's the context based on the fixes mentioned:

  1. Fixes [Switch] - Toggle functionality issue. #554 - Switch Toggle Functionality Issue:
  • This likely resolves an issue where the toggle switch was not behaving as expected. Instead of updating its position based on the defaultChecked prop, it was relying on checked, allowing it to handle process failures more effectively.

Test scope:

Case:

  • Ensure the switch does not toggle until the network request successfully completes.


  1. Fixes [Notification] - Stops showing after quick async operation. #555 - Notification Working After Quick Async Operation:
  • Clear the currently displayed notification when a new notification is triggered.
  • Ensures that notifications are displayed correctly even if an asynchronous operation takes quickly before the current notification is dismissed from the UI.


  1. Enhancement [TypeTable] - Width prop is not functional. #556 - Added Width Prop for Table:
  • Added a width prop to TypeTable to set a fixed width for table columns.

image



  1. Fixes [Top Bar] - Misalignment between text and icon of button. #557 - Fix Alignment Between Text and Icon of Top Bar:
  • Fix UI alignment issue where the text and icon in the top bar were not properly aligned, Removed margin-top: 7px from CSS.

image

@dev-shivang dev-shivang requested a review from isacoder March 3, 2025 13:30
@dev-shivang dev-shivang self-assigned this Mar 3, 2025
@dev-shivang dev-shivang requested a review from atomworks March 3, 2025 13:32
Copy link
Collaborator

@atomworks atomworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this but please could you break this down in to multiple PRs, one per issue so they can be reviewed individually. I've put a more detailed follow up note on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants