Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethy NotaryKeys does not update when forced era #865

Open
surangap opened this issue Jul 24, 2024 · 1 comment
Open

Ethy NotaryKeys does not update when forced era #865

surangap opened this issue Jul 24, 2024 · 1 comment

Comments

@surangap
Copy link
Contributor

surangap commented Jul 24, 2024

behavior

  • introduce a new validator during a session
  • force era
  • validator goes into pending at the start of the next session/end of the current session
    • notary_keys == x
    • next_notary_keys == x + y
  • at the start of the next session(S2) validator goes into the active validator list
    • but the notary_keys remain the same as above. does not update to the value of next_notary_keys

RCA
StakingSessionTracker returns the correct outputs, but if the validator becomes active at the start of the S2/ end of the S1, it would return is_active_session_final() false, which is correct. But the emergency notary keys rotation code path is within is_active_session_final scope. so it would not trigger.

notary_keys would be updated at the next natural era change

@surangap
Copy link
Contributor Author

surangap commented Jul 24, 2024

Code paths also confirmed on a local setup

@surangap surangap changed the title Ethy NotaryKeys update does not happen when forced era Ethy NotaryKeys does not update when forced era Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant