Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish a major version branch/tag #479

Closed
krzema12 opened this issue Jan 17, 2025 · 3 comments
Closed

Please publish a major version branch/tag #479

krzema12 opened this issue Jan 17, 2025 · 3 comments

Comments

@krzema12
Copy link
Contributor

Hi!

This action doesn't have a major version branch/tag. Per the recommendations in https://github.com/actions/toolkit/blob/main/docs/action-versioning.md#major-versions, it would be good to expose v0 branch that points to the newest full-version tag, currently 0.11.0.

BTW, not having v in front of the tag names is also a bit unusual, as far as I can tell after using a bunch of actions 😄

The reason I'm reporting it is that https://github.com/typesafegithub/github-workflows-kt can suggest updates to your action, if a new major version appears (full versions are not yet supported). I can imagine that you don't expose the major version ref on purpose, to force the action's clients to carefully migrate between each unstable release, but I thought I'll let you know in case you just forgot about it.

Best,
Piotr

@fwilhe2
Copy link
Owner

fwilhe2 commented Jan 22, 2025

Hi @krzema12

I've taken this as a reason to bump the version number to v1

I published a v0 and a v1 branch

I'm still missing automation to keep the v1 branch updated, this should be part of the github action doing the release, otherwise I'm sure I will forget about it.

@krzema12
Copy link
Contributor Author

@fwilhe2 not sure if GitHub provides any tools to help with the releases, but I implemented my workflow to keep the major version branch in sync, feel free to get some inspiration: https://github.com/typesafegithub/github-actions-typing/blob/main/.github/workflows/release.main.kts

@fwilhe2
Copy link
Owner

fwilhe2 commented Jan 22, 2025

REL_BRANCH=$(echo ${{ steps.bump.outputs.newVersion }} | cut --delimiter "." --fields 1)

tbh, not sure why I need to force push, the v1 branch was 1 commit behind main and had no commits that were not in main, but I've seen you use -f too

Not the most elegant solution, but it should work, I guess. Let's see, let me know if you find any issues.

@fwilhe2 fwilhe2 closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants