From b764b257974b05ecd55b74a623bfa9d40250cc3d Mon Sep 17 00:00:00 2001 From: Le-Roux Enslin Date: Fri, 13 Oct 2017 11:36:51 +0200 Subject: [PATCH] Added male and female titles for the en_ZA locale - The new titles are for Revenant (Rev.) and Honourable (Hon.) - Remove unused use import for Faker\Provider\DateTime --- src/Faker/Provider/en_ZA/Person.php | 5 ++++- test/Faker/Provider/en_ZA/PersonTest.php | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/Faker/Provider/en_ZA/Person.php b/src/Faker/Provider/en_ZA/Person.php index f0ec1ebb78..0bdb957470 100644 --- a/src/Faker/Provider/en_ZA/Person.php +++ b/src/Faker/Provider/en_ZA/Person.php @@ -3,7 +3,6 @@ namespace Faker\Provider\en_ZA; use Faker\Calculator\Luhn; -use Faker\Provider\DateTime; class Person extends \Faker\Provider\Person { @@ -127,6 +126,10 @@ class Person extends \Faker\Provider\Person 'Pule', 'Hlophe', 'Miya', 'Moagi', ); + protected static $titleMale = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.'); + + protected static $titleFemale = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.'); + protected static $licenceCodes = array('A', 'A1', 'B', 'C', 'C1', 'C2', 'EB', 'EC', 'EC1', 'I', 'L', 'L1'); /** diff --git a/test/Faker/Provider/en_ZA/PersonTest.php b/test/Faker/Provider/en_ZA/PersonTest.php index 3edda8df2b..a97ee62c0c 100644 --- a/test/Faker/Provider/en_ZA/PersonTest.php +++ b/test/Faker/Provider/en_ZA/PersonTest.php @@ -51,4 +51,18 @@ public function testLicenceCode() $this->assertContains($this->faker->licenceCode, $validLicenceCodes); } + + public function testMaleTitles() + { + $validMaleTitles = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.'); + + $this->assertContains(Person::titleMale(), $validMaleTitles); + } + + public function testFemaleTitles() + { + $validateFemaleTitles = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.'); + + $this->assertContains(Person::titleFemale(), $validateFemaleTitles); + } }