Build failure with current fmt head branch

[jcelerier]

Hello,
since fmt at commit fmtlib/fmt@16f2ef9

spdlog does not build, with the following error on win32 (latest MSVC):

spdlog\include\spdlog\common-inl.h(61,53): 
error C2664: 
'void fmt::v7::format_system_error(fmt::v7::detail::buffer<T> &,int,const char *) noexcept': 
cannot convert argument 3 from 'const std::string' to 'const char *'
          with
          [
              T=char
          ]

Not critical, but a heads-up :)

[jcelerier]

(small heads-up to @vitaut also in case the issue is in fmt instead of spdlog?)

[FreezePhoenix]

Believe it's because of the fact that FMT changed a handful of things, and Spdlog's local copy of the FMT API isn't synced.

[vitaut]

This is one of the system_error-related changes made in preparation for the major release. The (obvious) fix is to add .c_str().

[FreezePhoenix]

Side note that using the latest releases of both libspdlog and libfmt results in some unresolved symbols when trying to use them.

[lgbaldoni]

fmt 1.8.0 released and build failing.

[gabime]

Fixed in latest commit