Cannot get trivial read property innerHTML example working

[danneu]

Working through the README, I'm having trouble getting innerHTML to return anything beyond undefined.

x('select div {0,}[0] | read property textContent', '<div>hello</div>')
//=> 'hello'

x('select div {0,}[0] | read property innerHTML', '<div>hello</div>')
//=> undefined

[gajus]

Is this using the cheerio or browser executor?

[gajus]

The logic is pretty trivial:

surgeon/src/evaluators/cheerioEvaluator.js

Lines 24 to 40 in b43daf7

	const getPropertyValue = (node: Object, name: string): mixed => {
	if (name === 'textContent') {
	return node.text();
	}
	// @see https://github.com/cheeriojs/cheerio/issues/944
	if (name === 'outerHTML') {
	return node.clone().wrap('<div>').parent().html();
	}
	// @see https://github.com/cheeriojs/cheerio/issues/993
	if (name === 'childNodes') {
	return node[0].childNodes;
	}
	return node.prop(name);
	};

I am going to guess that for whatever reason innerHTML returns undefined in cheerio. It looks like it requires adding another if condition that checks if property name is innerHTML and uses .html() method to return the HTML.

[gajus]

It is a bug in cheerio, cheeriojs/cheerio#1099.

I have patched it locally.