fix: correct formatting of decimals in ds-test logs [WIP] #361
Conversation
`log_named_decimal_uint` incorrectly displays logs:
```
function testDecimals() public {
emit log_named_decimal_uint("balance", address(this).balance, 18);
emit log_named_decimal_uint("balance", 12345678, 18);
}
```
Before:
```
Success: testDecimals()
balance: 79228162514264340000000000000000000000000000000
balance: 12345678000000000000000000
```
After:
```
Success: testDecimals()
balance: "79228162514.264337593543950335"
balance: "0.000000000012345678"
```
ethers-rs `parse_units` restricts units to `u32` making numbers with large decimals like Maker's `rad` with 45 decimals crash.
Still need to convert from string to U256 or something... :|
| @@ -93,7 +93,7 @@ pub(crate) fn convert_log(log: Log) -> Option<String> { | |||
| format!( | |||
| "{}: {:?}", | |||
| inner.key, | |||
| ethers::utils::parse_units(inner.val, inner.decimals.as_u32()).unwrap() | |||
| ethers::utils::format_units(inner.val, inner.decimals.as_u32()).unwrap() | |||
There was a problem hiding this comment.
We also need this same change a few lines up for LogNamedDecimalIntFilter right?
There was a problem hiding this comment.
Yeah, although that may have to be an ethers-rs fix, getting this error when changing parse_units to format_units
ethers::utils::format_units(inner.val, inner.decimals.as_u32()).unwrap()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `From<ethers::prelude::I256>` is not implemented for `ethers::prelude::U256`
There was a problem hiding this comment.
Yeah we do not support I256 for format units:
You could do this here by getting the absolute value of the I256, formatting it as string, and then prepending a minus if its sign is a negative number.
There was a problem hiding this comment.
Adding support for I256 to ethers-rs is probably the best way to do this right? If so we can merge this PR, and I (or @nanexcool if you'd rather do it) can take a shot at adding I256 support to ethers-rs format_units, then follow up with a PR here to change LogNamedDecimalIntFilter to use format_units
There was a problem hiding this comment.
@mds1 I think I'm gonna do a couple of Rust tutorials first instead of heading straight for another PR 😂 Go for it!
There was a problem hiding this comment.
sounds good! I've been working my way through rustlings which has been pretty good, but please share any good rust tutorials you find! 😛
|
@nanexcool sorry to pull you back for a small change but figure you'll benefit from reading that part of the code, you need to make a small change in the test |
|
@gakonst all good! This is a learning experience for me! Seems I'm returning a String enclosed in |
| @@ -93,7 +93,7 @@ pub(crate) fn convert_log(log: Log) -> Option<String> { | |||
| format!( | |||
| "{}: {:?}", | |||
| inner.key, | |||
| ethers::utils::parse_units(inner.val, inner.decimals.as_u32()).unwrap() | |||
| ethers::utils::format_units(inner.val, inner.decimals.as_u32()).unwrap().parse::<f64>().unwrap() | |||
There was a problem hiding this comment.
This conversion does not exactly make sense, what do you want to achieve?
format_units takes a number and units and it formats them as a string. The double quotation marks you're seeing are due to the {:?} in the format!, which indicates that it uses the Debug impl of a String. You can change it to format!("{}: {}") and they should be gone.
There was a problem hiding this comment.
Ah, I see! Yes, I was basically trying to remove the double quotation marks. Will change the format and resubmit.
log_named_decimal_uintincorrectly displays logs:Before:
After:
ethers-rs
parse_unitsrestricts units tou32making numbers with large decimals like Maker'sradwith 45 decimals crash.