Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support % slippage limit #103

Open
mrq1911 opened this issue Jan 11, 2025 · 0 comments
Open

Support % slippage limit #103

mrq1911 opened this issue Jan 11, 2025 · 0 comments
Labels
area/sdk Related to trading router kind/enhancement Enhancement of existing functionality

Comments

@mrq1911
Copy link
Member

mrq1911 commented Jan 11, 2025

toTx currently expects only limit as absolute amount, would be useful to allow also {slippagePct: '1'} for router to calculate limit from context automatically to reduce errors, also it should be possible to not define limit at all - in that case the default (f.e. 1%) would be applied

these cases should be supported:

  • .toTx({limitPct: 1})
  • .toTx({limit: 123.33})
  • .toTx(123330000) (legacy support)
@nohaapav nohaapav added kind/enhancement Enhancement of existing functionality area/sdk Related to trading router labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk Related to trading router kind/enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants