-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List creation misses remove file extension option #9497
Comments
While working on the rewrite to Vue, I attempted to start working on this issue. However, there are a few problems with doing this that took this out of scope of the rewrite.
|
How is the extension removal working at the moment? Just splitting at the last |
Right now, list of pairs only removes the file extension from the pair name. It gets that file extension from the pairs themselves. Since pairs are renamed forward/reverse once you click create, it doesn't matter if the actual files have extensions or not. |
But yes, right now it removes the extension from the last period, which is a problem for .fastq.gz files. However, removing the longest extension seems overkill. It could make the name of some files indecipherable. For example, a file name called "aFileBob_1" with no extension would be renamed to "a" to get rid of the 9 characters to remove the whole .fastq.gz extension. There is definitely a way to resolve this. I just wanted to capture my quick thoughts from the rewrite so that when I come back to this later, I remember what I've already tried. |
Good point, but having > 1 files in a collection seems a reasonable assumption, then the longest common suffix should work. One could also think of a text input where users can specify what to be removed. The default could be the longest common suffix (or everything up to the last Still a special treatment of 1 file would |
But as you mentioned a special case for file names that do not contain a dot would be good. |
The checkbox:
Remove extensions ...
would be nice to have for creating lists. It already exists for paired list creation. So would also be nice for consistency.The text was updated successfully, but these errors were encountered: