Multiple warnings when compiling carat binaries

[jengelh]

$ make -j16 2>&1 | grep warning:
[download carat.tgz, etc.]
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
~/carat/carat/src/minpol.c:32:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/normalizer.c:30:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/normalizer.c:112:4: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/normalizer_in_n.c:28:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/normalizer_in_n.c:88:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/normlin.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/orbit.c:30:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/orbit.c:172:2: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/order.c:29:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/order.c:104:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/pair_red.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/pdet.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/perfect_neighbours.c:46:9: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/perfect_neighbours.c:52:15: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/perfect_neighbours.c:87:12: warning: implicit declaration of function ‘free_mat’; did you mean ‘get_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/polyeder.c:41:9: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/polyeder.c:46:15: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/polyeder.c:64:17: warning: implicit declaration of function ‘refine_polyeder’; did you mean ‘first_polyeder’? [-Wimplicit-function-declaration]
~/carat/carat/src/polyeder.c:66:9: warning: implicit declaration of function ‘put_polyeder’; did you mean ‘first_polyeder’? [-Wimplicit-function-declaration]
~/carat/carat/src/p_lse_solve.c:24:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/p_lse_solve.c:36:3: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/p_lse_solve.c:48:10: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/p_lse_solve.c:63:11: warning: implicit declaration of function ‘optionnumber’ [-Wimplicit-function-declaration]
~/carat/carat/src/p_lse_solve.c:69:6: warning: implicit declaration of function ‘put_mat’; did you mean ‘mget_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/red_gen.c:28:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/red_gen.c:89:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/rest_short.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/rest_short.c:39:9: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/rest_short.c:45:15: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/rest_short.c:54:18: warning: implicit declaration of function ‘optionnumber’ [-Wimplicit-function-declaration]
~/carat/carat/src/rest_short.c:72:13: warning: implicit declaration of function ‘free_mat’; did you mean ‘get_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/rein.c:28:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/rform.c:26:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/same_generators.c:29:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/same_generators.c:97:44: warning: implicit declaration of function ‘GGT’ [-Wimplicit-function-declaration]
~/carat/carat/src/same_generators.c:134:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/scalarmul.c:28:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/scpr.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/short.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/shortest.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/short_reduce.c:29:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/signature.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/signature.c:39:9: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/signature.c:52:16: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/signature.c:65:13: warning: implicit declaration of function ‘Check_mat’; did you mean ‘mget_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/signature.c:72:25: warning: implicit declaration of function ‘definite_test’ [-Wimplicit-function-declaration]
~/carat/carat/src/signature.c:90:17: warning: implicit declaration of function ‘free_mat’; did you mean ‘mget_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/simplify_mat.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/simplify_mat.c:61:17: warning: implicit declaration of function ‘gcd_mat’; did you mean ‘get_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/simplify_mat.c:82:18: warning: implicit declaration of function ‘GGT’ [-Wimplicit-function-declaration]
~/carat/carat/src/symbol.c:33:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/tsubgroups.c:38:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/tsubgroups.c:167:4: warning: implicit declaration of function ‘free_bravais’; did you mean ‘tr_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/tsupergroups.c:38:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/tsupergroups.c:103:4: warning: implicit declaration of function ‘free_bravais’; did you mean ‘tr_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/torsionfree.c:101:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]
~/carat/carat/src/tr.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/trace.c:25:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/trace.c:72:16: warning: implicit declaration of function ‘GGT’ [-Wimplicit-function-declaration]
~/carat/carat/src/tr_bravais.c:68:6: warning: implicit declaration of function ‘factorize_new’ [-Wimplicit-function-declaration]
~/carat/carat/src/vor_vertices.c:23:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/vor_vertices.c:39:9: warning: implicit declaration of function ‘read_header’ [-Wimplicit-function-declaration]
~/carat/carat/src/vor_vertices.c:45:15: warning: implicit declaration of function ‘is_option’ [-Wimplicit-function-declaration]
~/carat/carat/src/vor_vertices.c:61:14: warning: implicit declaration of function ‘free_mat’; did you mean ‘mget_mat’? [-Wimplicit-function-declaration]
~/carat/carat/src/vectoform.c:26:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/zass_main.c:29:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
~/carat/carat/src/zass_main.c:168:3: warning: implicit declaration of function ‘free_bravais’; did you mean ‘fput_bravais’? [-Wimplicit-function-declaration]

[olexandr-konovalov]

Thank you, @jengelh. It would be also helpful if you could specify the version of the compiler. Although, that's a legacy code which is ~10 years old, as https://wwwb.math.rwth-aachen.de/carat/ says, so most of the modern compilers will now complain.

Actually, as the README explains, this packages provides a GAP interface to CARAT software from https://wwwb.math.rwth-aachen.de/carat/ and the questions about the latter should be directed to [email protected].

[jengelh]

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/7/lto-wrapper
OFFLOAD_TARGET_NAMES=hsa:nvptx-none
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,ada,go --enable-offload-targets=hsa,nvptx-none=/usr/nvptx-none, --without-cuda-driver --enable-checking=release --disable-werror --with-gxx-include-dir=/usr/include/c++/7 --enable-ssp --disable-libssp --disable-libvtv --disable-libcc1 --enable-plugin --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --enable-version-specific-runtime-libs --with-gcc-major-version-only --enable-linker-build-id --enable-linux-futex --enable-gnu-indirect-function --program-suffix=-7 --without-system-libunwind --enable-multilib --with-arch-32=x86-64 --with-tune=generic --build=x86_64-suse-linux --host=x86_64-suse-linux
Thread model: posix
gcc version 7.3.1 20180817 [gcc-7-branch revision 263612] (SUSE Linux)

[olexandr-konovalov]

Hopefully this will be addressed at lbfm-rwth/carat#34

[gaehler]

The current release 2.3 contains a version of CARAT from GitHub (from 24 October 2019), in which most compilation warnings have already been addressed. Further such improvements may follow.

[fingolfin]

This is resolved; carat compiles warning free GCC 9.