Improve performance of CopyDigraph #331
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTWhyte
requested changes
Jul 31, 2020
There was a problem hiding this comment.
Hey @marinaanagno, this looks good to me. There's just one change I'd suggest: when you changed the name of the function, you forgot to delete its old declaration, which is easily done since it's in a different file!
gap/digraph.gd
Outdated
| @@ -14,6 +14,7 @@ DeclareCategory("IsDigraphWithAdjacencyFunction", IsDigraph); | |||
| DeclareCategory("IsCayleyDigraph", IsDigraph); | |||
| DeclareCategory("IsImmutableDigraph", IsDigraph); | |||
| DeclareSynonym("IsMutableDigraph", IsDigraph and IsMutable); | |||
| DeclareFilter("IsNotDefaultEdgeLabelled", IsDigraph); | |||
There was a problem hiding this comment.
Suggested change
| DeclareFilter("IsNotDefaultEdgeLabelled", IsDigraph); |
I think you meant to delete this line
There was a problem hiding this comment.
Thanks @MTWhyte! Just did this!
There was a problem hiding this comment.
Thanks @marinaanagno! Let's see if @james-d-mitchell has anything to say before merging.
MTWhyte
approved these changes
Aug 1, 2020
james-d-mitchell
requested changes
Aug 12, 2020
added 2 commits
August 13, 2020 10:02
james-d-mitchell
added
the
performance
|
@marinaanagno @samanthaharper I'm happy with this except one thing, you added some whitespace in 3 places, I just updated the PR to remove it, when the CI runs we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a filter called
IsNotDefaultEdgeLabelledthat changes to true when we set edge labels and changes back into false when we clear them, so now when we copy digraphs edges are only copied if they are not the default ones, which improves efficiency.This addresses issue #292.