Cayley digraphs #348
Cayley digraphs #348
Conversation
|
@james-d-mitchell This is failing because there is no code coverage of the new |
|
Ooops, forgot to write the doc and the tests. Done it now. |
james-d-mitchell
force-pushed
the
cayley
branch
2 times, most recently
from
b63a1c6 to
d2fce10
Compare
doc/fropin.xml
Outdated
| <C>PositionCanonical(<A>S</A>, AsListCanonical(<A>S</A>)[i] * | ||
| GeneratorsOfSemigroup(<A>S</A>)[j])</C>. | ||
| The list returned by <C>LeftCayleyGraphSemigroup</C> is defined analogously. | ||
| The list returned by <C>LeftCayleyDigraph</C> is defined analogously.<P/> |
There was a problem hiding this comment.
This sentence implies that <C>LeftCayleyDigraph</C> returns a list, rather than a digraph.
There was a problem hiding this comment.
Corrected
| @@ -391,8 +391,6 @@ function(S) | |||
|
|
|||
| l := LeftCayleyGraphSemigroup(S); | |||
| r := RightCayleyGraphSemigroup(S); | |||
| # WW: in the future, when l and r are digraphs, gr can be created | |||
| # by using DigraphEdgeUnion(l, r) | |||
There was a problem hiding this comment.
Is there a reason why you didn't implement this suggestion?
There was a problem hiding this comment.
Yes, because there are no methods for Left/RightCayleyDigraph for semigroups not in the category IsEnumerableSemigroupRep and so we use Left/RightCayleyGraphSemigroup which are defined in the library and hence not digraphs. So, basically the comment does not make sense in this method, although it does in the method for enumerable semigroups. Hence I deleted it.
| <Description> | ||
| If <A>digraph</A> is a <Ref Oper="Digraph" BookName="digraphs"/> in the | ||
| category <Ref Filt="IsCayleyDigraph" BookName="digraphs"/>, then | ||
| <C>DotString</C> returns a graphical representation of <A>digraph</A>. |
There was a problem hiding this comment.
I think you should be more descriptive about what the representation actually shows.
There was a problem hiding this comment.
We agreed this was not necessary.
These essentially just wrap the value previously returned by Left/RightCayleyGraphSemigroup in a Digraph object. Methods for Left/RightCayleyGraphSemigroup continue to exist (just calling OutNeighbours(Left/RightCayleyDigraph) since they are defined in the library. All other occurrences of Left/RightCayleyGraphSemigroup are replaced with Left/RightCayleyDigraph.
Using dot or tikz, for digraphs and semigroups.
|
Updated according to your comments @wi |
|
Travis is failing but it's not related to this PR. I'm trying to see if I can sort it out before merging. |
Replace
Left/RightCayleyGraphSemigroupwithLeft/RightCayleyDigraphand introduce some functions for drawing these objects. This PR requires Digraphs version 0.10.0 which is not yet released, so the tests will probably fail.These essentially just wrap the value previously returned by
Left/RightCayleyGraphSemigroupin aDigraphobject. Methods forLeft/RightCayleyGraphSemigroupcontinue to exist (just callingOutNeighbours(Left/RightCayleyDigraph)since they are defined in thelibrary. All other occurrences of
Left/RightCayleyGraphSemigrouparereplaced with
Left/RightCayleyDigraph.