Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "testinstall" and "teststandard" to something more clear #544

Open
fingolfin opened this issue Jan 27, 2016 · 5 comments
Open

Rename "testinstall" and "teststandard" to something more clear #544

fingolfin opened this issue Jan 27, 2016 · 5 comments
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests

Comments

@fingolfin
Copy link
Member

For a new comer, it is not at all clear why "testinstall" is named the way it is. Yeah, we could explain... but I think it's much better to just use names that are easy to understand.

Some ideas for new names:

  • fasttest and fulltest
  • test-fast and test-full
  • test-fast and test-all

The new names should be at least used for the make targets. For tst/testinstall, we could of course just rename that to the new name -- but it would also be possible to shorten that, e.g. tst/fast

One concern with that: it might be confusing if make test-full runs the tests from tst/full and tst/fast ... but I personally don't worry about that...

Any better ideas?

@fingolfin fingolfin self-assigned this Jan 27, 2016
@fingolfin fingolfin added the topic: tests issues or PRs related to tests label Jan 27, 2016
@fingolfin
Copy link
Member Author

As @markuspf just pointed out to me, of course teststandard does not at all run all tests -- there are also the manual examples!

I think a test-all or test-full target really should run all tests. So, perhaps teststandard should just retain that name, or perhaps be changed to test, with siblings test-quick and test-all or so

@olexandr-konovalov
Copy link
Member

And there are other test... targets, not only manual examples - e.g. testpackages, testobsoletes, testupdates etc., maybe testcoverage soon (like that idea).

So I am happy with teststandard to stay. Don't mind testinstall to became quicktest or so.

@hungaborhorvath
Copy link
Contributor

I second that these names are far from self-explanatory. I have created 3 or 4 (quick) test files in the past month, and still am not entirely sure whether they should go to install or standard....

@frankluebeck
Copy link
Member

However you want to rename the files: I would be nice if you kept testinstall.g at least as a soft link (even if undocumented) to the benefit of those gap users/administrators who read this file since many years as a quick test after installation.

@olexandr-konovalov
Copy link
Member

Please see the new proposal for the naming conventions and structure of the test files written by @markuspf : https://github.com/gap-system/gap/wiki/Testing-methods-and-targets

@fingolfin fingolfin removed their assignment Jan 19, 2017
@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests
Projects
None yet
Development

No branches or pull requests

4 participants