-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "testinstall" and "teststandard" to something more clear #544
Comments
As @markuspf just pointed out to me, of course I think a |
And there are other So I am happy with |
I second that these names are far from self-explanatory. I have created 3 or 4 (quick) test files in the past month, and still am not entirely sure whether they should go to install or standard.... |
However you want to rename the files: I would be nice if you kept |
Please see the new proposal for the naming conventions and structure of the test files written by @markuspf : https://github.com/gap-system/gap/wiki/Testing-methods-and-targets |
For a new comer, it is not at all clear why "testinstall" is named the way it is. Yeah, we could explain... but I think it's much better to just use names that are easy to understand.
Some ideas for new names:
fasttest
andfulltest
test-fast
andtest-full
test-fast
andtest-all
The new names should be at least used for the
make
targets. Fortst/testinstall
, we could of course just rename that to the new name -- but it would also be possible to shorten that, e.g.tst/fast
One concern with that: it might be confusing if
make test-full
runs the tests fromtst/full
andtst/fast
... but I personally don't worry about that...Any better ideas?
The text was updated successfully, but these errors were encountered: