Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in ClassPositionsOfLowerCentralSeries #3321

Closed
ThomasBreuer opened this issue Mar 1, 2019 · 1 comment
Closed

bug in ClassPositionsOfLowerCentralSeries #3321

ThomasBreuer opened this issue Mar 1, 2019 · 1 comment
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Milestone

Comments

@ThomasBreuer
Copy link
Contributor

ThomasBreuer commented Mar 1, 2019

Frieder Ladisch had reported the following bug:

gap> g:= SmallGroup( 3^5, 22 );;
gap> LowerCentralSeries(g);
[ C27 : C9, Group([ f3, f5 ]), Group([ f5 ]), Group([ <identity> of ... ]) ]
gap> ct:= CharacterTable(g);;
gap> ClassPositionsOfLowerCentralSeries(ct);
[ [ 1 .. 35 ], [ 1, 4, 6, 12, 15 ] ]

Looking at the code, I found related issues:

  • ElementaryAbelianSeries runs into an error if the argument is a nonsolvable group.
    According to the documentation, fail should be returned.
    I think the function should be adjusted to the documentation.
    (The corresponding function ClassPositionsOfElementaryAbelianSeries returns fail
    for character tables of nonsolvable groups.)
  • UpperCentralSeries returns a descending series,
    whereas ClassPositionsOfUpperCentralSeries returns an ascending series.
    The documentation of UpperCentralSeries coincides with the return value.
    Here I am not sure what to do.
  • In order to run a reasonable amount of tests (on small groups) that compare the
    ClassPositionsOf... functions with the corresponding functions for groups,
    it makes sense to improve the code of some ClassPositionsOf... methods.

I will provide a pull request.

@ThomasBreuer ThomasBreuer added the kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them label Mar 1, 2019
@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 21, 2019
@fingolfin
Copy link
Member

Fixed by #3347

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.2 milestone Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

No branches or pull requests

3 participants