Use different path pattern for caching certificates #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
fix/support-symlinked-cert-directory
branch
4 times, most recently
from
ac144de to
587c270
Compare
NotTheEvilOne
force-pushed
the
fix/support-symlinked-cert-directory
branch
2 times, most recently
from
3fab69f to
2f455cc
Compare
This change adds support for symlinked `cert` directories. Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
fix/support-symlinked-cert-directory
branch
from
2f455cc to
4dbd8d7
Compare
Vincinator
reviewed
Feb 26, 2025
| with: | ||
| path: cert | ||
| path: cert/*.* |
There was a problem hiding this comment.
thanks for taking care of this.
Interesting that this action references actions/toolkit but do not seem to expose the follow-symbolic-links feature, at least I could not find it in actions/cache repo.
Do you have a test run that you can link by any chance?
Otherwise looks good to me
There was a problem hiding this comment.
I would assume that cert/*.* would force the action to follow the symlinks via wildcard (implemented by mentioned https://github.com/actions/toolkit/tree/main/packages/glob)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for symlinked
certdirectories like used forgardenlinux-ccloud.Which issue(s) this PR fixes:
Fixes gardenlinux/gardenlinux-ccloud#42