feat(gatsby-plugin-typescript): allow specifying babel preset options #10248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
requested changes
Dec 3, 2018
There was a problem hiding this comment.
Verified locally and works nicely. Only request is to add section in documentation ( https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-typescript/README.md ) to describe how to pass options to @babel/preset-typescript
|
@pieh Good call! Just updated the README 👍 |
pieh
approved these changes
Dec 4, 2018
|
Ops, some linting problem - I'll just fix that really quick and merge |
pieh
changed the title
pieh
changed the title
|
Holy buckets, @colebemis — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
m-allanson
added a commit
to Bouncey/gatsby
that referenced
this pull request
Dec 7, 2018
* master: (1595 commits) chore: update link for react-gatsby-firebase-authentication (gatsbyjs#10314) fix(www): Awesome Gatsby sidebar link (gatsbyjs#10313) Add thijs koerselman to creators list (gatsbyjs#10303) chore(release): Publish fix(gatsby-plugin-emotion): allow for React.Fragment shorthand syntax (gatsbyjs#10291) feat(www): Update starter cards (gatsbyjs#10258) Update index.md (gatsbyjs#10307) Update index.md (gatsbyjs#10306) Add thijs koerselman portfolio to sites list (gatsbyjs#10304) chore(release): Publish fix(gatsby): don't remount matchPath pages (gatsbyjs#10261) chore(release): Publish feat(gatsby-source-contentful): enable RichText for all users (gatsbyjs#10301) docs(tutorial): update 404 screenshot (gatsbyjs#10295) feat(gatsby-plugin-typescript): allow specifying babel preset options (gatsbyjs#10248) docs(gatsby-plugin-sass): fix typo in docs (gatsbyjs#10292) fix(ci): actually only run tests on non-docs changes (gatsbyjs#10287) fix(blog): rename for correct date in link (gatsbyjs#10290) Adds a more descriptive link purpose (gatsbyjs#9266) fix(www): comment out down showcase site ...
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…gatsbyjs#10248) * Pass through babel preset options * Add options section to gatsby-plugin-typescript docs * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/preset-typescriptaccepts options but there is currently no way to set those options withgatsby-plugin-typescript. This pull passes the plugin options to the babel preset.